Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[influxdb] Treat a stored 1 AND 1.0 as true #9545

Merged
merged 2 commits into from Dec 29, 2020

Conversation

t2000
Copy link
Contributor

@t2000 t2000 commented Dec 27, 2020

Fixes #9455

Signed-off-by: Stefan Triller github@stefantriller.de

Fixes openhab#9455

Signed-off-by: Stefan Triller <github@stefantriller.de>
@t2000 t2000 requested a review from lujop as a code owner December 27, 2020 20:23
@t2000
Copy link
Contributor Author

t2000 commented Dec 27, 2020

close and re-open to trigger rebuild

@t2000 t2000 closed this Dec 27, 2020
@t2000 t2000 reopened this Dec 27, 2020
Copy link
Contributor

@lujop lujop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good to me. But can you add that case in InfluxDBStateConvertUtilsTest

Signed-off-by: Stefan Triller <github@stefantriller.de>
@t2000
Copy link
Contributor Author

t2000 commented Dec 28, 2020

Of course, sure. I have added the test case. Thanks for the review.

@Hilbrand Hilbrand added the bug An unexpected problem or unintended behavior of an add-on label Dec 28, 2020
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wborn wborn merged commit bf2d40c into openhab:main Dec 29, 2020
@t2000 t2000 deleted the fixInfluxDbSwitch branch December 29, 2020 15:04
@wborn wborn added this to the 3.1 milestone Dec 29, 2020
nowaterman pushed a commit to nowaterman/openhab-addons that referenced this pull request Jan 19, 2021
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/historicstate-always-gets-closed-value/116915/2

wborn pushed a commit to wborn/openhab-addons that referenced this pull request Feb 18, 2021
Signed-off-by: Stefan Triller <github@stefantriller.de>
@wborn wborn added the patch A PR that has been cherry-picked to a patch release branch label Feb 18, 2021
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
Signed-off-by: Stefan Triller <github@stefantriller.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Signed-off-by: Stefan Triller <github@stefantriller.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[influxdb] historic states of switch items are always OFF with influxdb v1
5 participants