[teleinfo] Fix memory leak #9724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivierkeke
changed the title
olivierkeke
changed the title
cpmeister
requested changes
Jan 6, 2021
...a/org/openhab/binding/teleinfo/internal/handler/TeleinfoAbstractElectricityMeterHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Olivier Marceau <hollysaiqs@marceau.ovh>
Signed-off-by: Olivier Marceau <hollysaiqs@marceau.ovh>
olivierkeke
force-pushed
the
listener-memory-leak
branch
from
11cb5cc
to
0342cb8
Compare
|
@cpmeister Thank you for the tip! I've pushed a new version of the fix, can you check? |
cpmeister
requested changes
Jan 10, 2021
| if (bridgeStatusInfo.getStatus() != ThingStatus.ONLINE) { | ||
| if (controllerHandler != null) { | ||
| controllerHandler.removeListener(this); |
There was a problem hiding this comment.
You should make sure that this gets called when the TeleinfoAbstractElectricityMeterHandler is disposed as well.
Looks like you need to override the dispose method to get that done.
Signed-off-by: Olivier Marceau <hollysaiqs@marceau.ovh>
wborn
added
rebuild
cpmeister
approved these changes
Jan 13, 2021
nowaterman
pushed a commit
to nowaterman/openhab-addons
that referenced
this pull request
Jan 19, 2021
* Use set instead list to avoid duplicate listeners * Remove from listeners when bridge is not ONLINE * Unsubscribe from bridge handler events when thing handler is disposed
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
* Use set instead list to avoid duplicate listeners * Remove from listeners when bridge is not ONLINE * Unsubscribe from bridge handler events when thing handler is disposed Signed-off-by: Olivier Marceau <hollysaiqs@marceau.ovh> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
* Use set instead list to avoid duplicate listeners * Remove from listeners when bridge is not ONLINE * Unsubscribe from bridge handler events when thing handler is disposed Signed-off-by: Olivier Marceau <hollysaiqs@marceau.ovh>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* Use set instead list to avoid duplicate listeners * Remove from listeners when bridge is not ONLINE * Unsubscribe from bridge handler events when thing handler is disposed Signed-off-by: Olivier Marceau <hollysaiqs@marceau.ovh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #9546.
This PR prevents the
ThingHandlerfrom registering more than once to the bridge event when abridgeStatusChangedis triggered.