Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[samsungtv] Fixed device.getIdentity().getDescriptorURL() comparison #9762

Merged
merged 1 commit into from Jan 9, 2021
Merged

[samsungtv] Fixed device.getIdentity().getDescriptorURL() comparison #9762

merged 1 commit into from Jan 9, 2021

Conversation

morph166955
Copy link
Contributor

Fixes #9673

@kaikreuzer @paulianttila Requesting you review and approve.

@morph166955
Fixes #9673
cca8b47 
Signed-off-by: morph166955 <rosenblumb@gmail.com>
kaikreuzer
kaikreuzer approved these changes Jan 9, 2021
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for looking into it!
This is indeed a bug I introduced when porting the other PR and extracting the essential changes from it. I had to negate many statements and this one slipped through as it seems...

@kaikreuzer kaikreuzer added this to the 3.1 milestone Jan 9, 2021
@kaikreuzer kaikreuzer merged commit 2549870 into openhab:main Jan 9, 2021
@kaikreuzer kaikreuzer changed the title [samsungtv] Fixes device.getIdentity().getDescriptorURL() comparison [samsungtv] Fixed device.getIdentity().getDescriptorURL() comparison Jan 9, 2021
@morph166955
Copy link
Contributor Author

Thanks @kaikreuzer. I'm still intrigued that your TV was working and mine wasn't. I'm worried there is a difference where this could break yours. Please definitely make sure yours still works after this change

nowaterman pushed a commit to nowaterman/openhab-addons that referenced this pull request Jan 19, 2021
@morph166955
Fixes openhab#9673 (openhab#9762)
6f51b7a
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-3-1-milestone-discussion/116025/2

themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
@morph166955 @themillhousegroup
Fixes openhab#9673 (openhab#9762)
bca9f18 
Signed-off-by: morph166955 <rosenblumb@gmail.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@morph166955 @thinkingstone
Fixes openhab#9673 (openhab#9762)
5cbb97e 
Signed-off-by: morph166955 <rosenblumb@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@morph166955
Fixes openhab#9673 (openhab#9762)
7d555b8 
Signed-off-by: morph166955 <rosenblumb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

[samsungtv] 3.1.0-S2112 breaks all functionality
3 participants
@morph166955 @openhab-bot @kaikreuzer