Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ipcamera] Fixes for Instar and HLS. #9766

Merged
merged 2 commits into from
Jan 13, 2021
Merged

[ipcamera] Fixes for Instar and HLS. #9766

merged 2 commits into from
Jan 13, 2021

Conversation

Skinah
Copy link
Contributor

@Skinah Skinah commented Jan 10, 2021 •
edited
Loading

Changes fix a few bugs:

  1. openHAB 3 does not seem to send a REFRESH command to all channels anymore so the Instar alarm server does not get setup correctly as it relied on getting this command sent. The change now also allows any serverPort changes to updated instantly to the cameras settings to keep things working.
  2. HLS would some times not auto stop due to a bug in the keepAlive code.

Signed-off-by: Matthew Skinner matt@pcmus.com

@Skinah
Fix for Instar and HLS.
ee46f45 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
Merge branch 'main' into ipcamera
e838d3d
@Skinah Skinah added rebuild Triggers Jenkins PR build enhancement An enhancement or new feature for an existing add-on bug An unexpected problem or unintended behavior of an add-on and removed rebuild Triggers Jenkins PR build labels Jan 10, 2021
fwolter
fwolter approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Your code uses scheduleAtFixedRate(). That should be replaced by scheduleWithFixedDelay() as it stresses the system less. Can you file a follow-up PR?

@fwolter fwolter merged commit ec1a91c into openhab:main Jan 13, 2021
@fwolter fwolter added this to the 3.1 milestone Jan 13, 2021
nowaterman pushed a commit to nowaterman/openhab-addons that referenced this pull request Jan 19, 2021
@Skinah
[ipcamera] Fix for Instar and HLS. (openhab#9766)
f660887
@Skinah Skinah deleted the ipcamera branch February 1, 2021 02:22
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
@Skinah @themillhousegroup
[ipcamera] Fix for Instar and HLS. (openhab#9766)
e9927be 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@Skinah @thinkingstone
[ipcamera] Fix for Instar and HLS. (openhab#9766)
5c5505b 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@Skinah
[ipcamera] Fix for Instar and HLS. (openhab#9766)
cd99e27 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwolter fwolter fwolter approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Skinah @fwolter