Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draytonwiser] MDNS Fixes #9806

Merged
merged 1 commit into from Jan 13, 2021
Merged

[draytonwiser] MDNS Fixes #9806

merged 1 commit into from Jan 13, 2021

Conversation

jamesmelville
Copy link
Contributor

Small bugfixes for MDNS discovery functionality:

  1. Fixes [drayton wiser] DraytonWiserMDNSDiscoveryParticipant' threw an exception - ID segment contains invalid characters #8786 invalid uid on discovered hub
  2. Resolve issue on startup in OH3 for discovery result without address, reported here https://community.openhab.org/t/drayton-wiser-thermostat-binding/35640/402

1. Fixes openhab#8786 invalid uid on discovered hub
2. Resolve issue on startup in OH3 discovery result without address

Signed-off-by: James Melville <jamesmelville@gmail.com>
@Hilbrand Hilbrand added the bug An unexpected problem or unintended behavior of an add-on label Jan 13, 2021
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. LGTM

@Hilbrand Hilbrand merged commit e9b1e35 into openhab:main Jan 13, 2021
@Hilbrand Hilbrand added this to the 3.1 milestone Jan 13, 2021
nowaterman pushed a commit to nowaterman/openhab-addons that referenced this pull request Jan 19, 2021
1. Fixes openhab#8786 invalid uid on discovered hub
2. Resolve issue on startup in OH3 discovery result without address
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
1. Fixes openhab#8786 invalid uid on discovered hub
2. Resolve issue on startup in OH3 discovery result without address

Signed-off-by: James Melville <jamesmelville@gmail.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
1. Fixes openhab#8786 invalid uid on discovered hub
2. Resolve issue on startup in OH3 discovery result without address

Signed-off-by: James Melville <jamesmelville@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
1. Fixes openhab#8786 invalid uid on discovered hub
2. Resolve issue on startup in OH3 discovery result without address

Signed-off-by: James Melville <jamesmelville@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
2 participants