Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jablotron] fixed programmable gates channels are not visible in the O… #9809

Merged
merged 1 commit into from Jan 13, 2021

Conversation

octa22
Copy link
Contributor

@octa22 octa22 commented Jan 12, 2021

this is a bugfix for a reported problem that channels for programmable gates are missing by the JA100 thing in OH3.
what is interesting, the channels were existing, but they were not visible in the UI channels tab.
This is a different behaviour from the OH2. After this bugfix they not only exist but they are visible as well ;-)

@octa22 octa22 added the bug An unexpected problem or unintended behavior of an add-on label Jan 12, 2021
@octa22 octa22 changed the title [jablotron] fixed programmable gates channel are not visible in the O… [jablotron] fixed programmable gates channels are not visible in the O… Jan 12, 2021
…OH3 UI

Signed-off-by: Ondrej Pecta <opecta@gmail.com>
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Yes, you are right. This is a different behavior of the new Main UI. There is an ongoing discussion about it in openhab/openhab-webui#406. In general it is recommended to always set a channel type. But it is not mandatory.

@cweitkamp cweitkamp added this to the 3.1 milestone Jan 13, 2021
@cweitkamp cweitkamp merged commit 41f8ae6 into openhab:main Jan 13, 2021
nowaterman pushed a commit to nowaterman/openhab-addons that referenced this pull request Jan 19, 2021
…OH3 UI (openhab#9809)

- fixed programmable gates channels are not visible in the OH3 UI
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
…OH3 UI (openhab#9809)

- fixed programmable gates channels are not visible in the OH3 UI

Signed-off-by: Ondrej Pecta <opecta@gmail.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
…OH3 UI (openhab#9809)

- fixed programmable gates channels are not visible in the OH3 UI

Signed-off-by: Ondrej Pecta <opecta@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
…OH3 UI (openhab#9809)

- fixed programmable gates channels are not visible in the OH3 UI

Signed-off-by: Ondrej Pecta <opecta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants