[pidcontroller] Fix for handling trigger input in action #9842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
keys in action context from trigger are passed with prefix of trigger name. This change removes the prefix to get the actual name and checks if it matches an item. Else it tries the original name. Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
fwolter
requested changes
Jan 16, 2021
| @@ -204,7 +204,7 @@ private double getItemValueAsNumber(Item item) throws PIDException { | |||
|
|
|||
| @Override | |||
| public void receive(Event event) { | |||
| if (event instanceof ItemStateChangedEvent) { | |||
| if (event instanceof ItemStateChangedEvent && commandTopic.isPresent()) { | |||
There was a problem hiding this comment.
This won't invoke calculate() anymore if no command item is set.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
nowaterman
pushed a commit
to nowaterman/openhab-addons
that referenced
this pull request
Jan 19, 2021
* [pidcontroller] Catch empty commandTopic * [pidcontroller] Fix handling action keys in action context from trigger are passed with prefix of trigger name. This change removes the prefix to get the actual name and checks if it matches an item. Else it tries the original name. * [pidcontroller] review comment
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
* [pidcontroller] Catch empty commandTopic Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl> * [pidcontroller] Fix handling action keys in action context from trigger are passed with prefix of trigger name. This change removes the prefix to get the actual name and checks if it matches an item. Else it tries the original name. Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl> * [pidcontroller] review comment Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
* [pidcontroller] Catch empty commandTopic Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl> * [pidcontroller] Fix handling action keys in action context from trigger are passed with prefix of trigger name. This change removes the prefix to get the actual name and checks if it matches an item. Else it tries the original name. Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl> * [pidcontroller] review comment Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* [pidcontroller] Catch empty commandTopic Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl> * [pidcontroller] Fix handling action keys in action context from trigger are passed with prefix of trigger name. This change removes the prefix to get the actual name and checks if it matches an item. Else it tries the original name. Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl> * [pidcontroller] review comment Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.