Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mystrom] Add support for myStrom Bulb #9910

Merged
merged 6 commits into from Feb 23, 2021
Merged

[mystrom] Add support for myStrom Bulb #9910

merged 6 commits into from Feb 23, 2021

Conversation

Fredo70
Copy link
Contributor

@Fredo70 Fredo70 commented Jan 22, 2021 •
edited

Add support for myStrom Bulb
Add properties to myStrom devices and an action to refresh the properties.
closes #9818

Signed-off-by: Frederic Chastagnol fchastagnol@fredoware.ch

@Fredo70
Add support to myStrom Bulb
a7fc862 
Add properties to myStrom devices and an action to refresh the properties.

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>
@Fredo70 Fredo70 requested a review from pail23 as a code owner January 22, 2021 13:24
@Hilbrand Hilbrand added the enhancement An enhancement or new feature for an existing add-on label Jan 22, 2021
J-N-K
J-N-K requested changes Jan 23, 2021
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution. I have left some comments inside. If you need assistance, plese ping me.

bundles/org.openhab.binding.mystrom/README.md Outdated Show resolved Hide resolved
...nding.mystrom/src/main/java/org/openhab/binding/mystrom/internal/MyStromAbstractHandler.java Outdated Show resolved Hide resolved
...nding.mystrom/src/main/java/org/openhab/binding/mystrom/internal/MyStromAbstractHandler.java Outdated Show resolved Hide resolved
...nding.mystrom/src/main/java/org/openhab/binding/mystrom/internal/MyStromAbstractHandler.java Outdated Show resolved Hide resolved
...nding.mystrom/src/main/java/org/openhab/binding/mystrom/internal/MyStromAbstractHandler.java Outdated Show resolved Hide resolved
bundles/org.openhab.binding.mystrom/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.mystrom/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
...b.binding.mystrom/src/main/java/org/openhab/binding/mystrom/internal/MyStromBulbHandler.java Outdated Show resolved Hide resolved
...nding.mystrom/src/main/java/org/openhab/binding/mystrom/internal/MyStromAbstractHandler.java Outdated Show resolved Hide resolved
...nding.mystrom/src/main/java/org/openhab/binding/mystrom/internal/MyStromAbstractHandler.java Outdated Show resolved Hide resolved
@Fredo70
Copy link
Contributor Author

Fredo70 commented Jan 23, 2021

I think I have adjusted everything. But before I commit, I have one more question.
Is it possible, for the channel "ColorTemperature", to set the default widget automatically as a slider with min=1, max=18 and step=1.
I looked in other addons and thought it was done with the <state min="1" max="18" step="1" pattern="%d"/> in the channel-type. But it always just comes up as a number with the analysis and I have to set the default widget manually.

@J-N-K
Copy link
Member

J-N-K commented Jan 23, 2021

Not sure. Maybe adding <category>slider</category> helps.

@Fredo70
Fixes according to review comments
8af98a6 
Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>
@Fredo70 Fredo70 requested a review from J-N-K January 24, 2021 11:03
J-N-K
J-N-K requested changes Jan 24, 2021
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some last small comments. Otherwise looks good to me.

bundles/org.openhab.binding.mystrom/README.md Outdated Show resolved Hide resolved
...b.binding.mystrom/src/main/java/org/openhab/binding/mystrom/internal/MyStromBulbHandler.java Outdated Show resolved Hide resolved
...b.binding.mystrom/src/main/java/org/openhab/binding/mystrom/internal/MyStromBulbHandler.java Outdated Show resolved Hide resolved
Fredo70 and others added 2 commits January 24, 2021 13:02
@Fredo70 @J-N-K
Update bundles/org.openhab.binding.mystrom/README.md
8ae1ec5 
Co-authored-by: J-N-K <J-N-K@users.noreply.github.com>
@Fredo70
Fixes according to review comments
b080bc6 
Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>
@J-N-K
Copy link
Member

J-N-K commented Jan 24, 2021 •
edited

Override DCO because "commit suggestion" was used. Waiting for Jenkins before merge.

Thanks.

@J-N-K J-N-K added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 24, 2021
@J-N-K J-N-K closed this Jan 24, 2021
@J-N-K J-N-K reopened this Jan 24, 2021
@J-N-K J-N-K added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 24, 2021
@J-N-K
Copy link
Member

J-N-K commented Jan 25, 2021

Jenkins failed prior to building mystrom. Rebuild.

pail23
pail23 approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@pail23 pail23 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for this contribution

@Fredo70
Use system color temperature channel type
219b838 
channel type system.color-temperature is used and values mapped from 1-18 to 0-100%

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>
@Fredo70
Better tracking of colour and brightness values
5909678 
Format power state
Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>
@Fredo70
Copy link
Contributor Author

Fredo70 commented Feb 11, 2021

There is still DCO issue because I used once "commit suggestion". Can I do something to make the check pass?

@fwolter
Copy link
Member

fwolter commented Feb 23, 2021

Kai's findings seem to be addressed appropriately.

@fwolter fwolter merged commit 7050a14 into openhab:main Feb 23, 2021
@fwolter fwolter added this to the 3.1 milestone Feb 23, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
@Fredo70 @J-N-K @themillhousegroup
[mystrom] Add support for myStrom Bulb (openhab#9910)
5e35518 
* Add support to myStrom Bulb

Add properties to myStrom devices and an action to refresh the properties.

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

* Fixes according to review comments

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

* Update bundles/org.openhab.binding.mystrom/README.md

Co-authored-by: J-N-K <J-N-K@users.noreply.github.com>

* Fixes according to review comments

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

* Use system color temperature channel type

channel type system.color-temperature is used and values mapped from 1-18 to 0-100%

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

* Better tracking of colour and brightness values

Format power state
Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

Co-authored-by: J-N-K <J-N-K@users.noreply.github.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request May 15, 2021
@Fredo70 @J-N-K @lucacalcaterra
[mystrom] Add support for myStrom Bulb (openhab#9910)
f4ab202 
* Add support to myStrom Bulb

Add properties to myStrom devices and an action to refresh the properties.

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

* Fixes according to review comments

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

* Update bundles/org.openhab.binding.mystrom/README.md

Co-authored-by: J-N-K <J-N-K@users.noreply.github.com>

* Fixes according to review comments

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

* Use system color temperature channel type

channel type system.color-temperature is used and values mapped from 1-18 to 0-100%

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

* Better tracking of colour and brightness values

Format power state
Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

Co-authored-by: J-N-K <J-N-K@users.noreply.github.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
@Tom852 Tom852 mentioned this pull request Jun 7, 2021
Closed
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
@Fredo70 @J-N-K @computergeek1507
[mystrom] Add support for myStrom Bulb (openhab#9910)
5539b7d 
* Add support to myStrom Bulb

Add properties to myStrom devices and an action to refresh the properties.

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

* Fixes according to review comments

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

* Update bundles/org.openhab.binding.mystrom/README.md

Co-authored-by: J-N-K <J-N-K@users.noreply.github.com>

* Fixes according to review comments

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

* Use system color temperature channel type

channel type system.color-temperature is used and values mapped from 1-18 to 0-100%

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

* Better tracking of colour and brightness values

Format power state
Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

Co-authored-by: J-N-K <J-N-K@users.noreply.github.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@Fredo70 @J-N-K @thinkingstone
[mystrom] Add support for myStrom Bulb (openhab#9910)
febd308 
* Add support to myStrom Bulb

Add properties to myStrom devices and an action to refresh the properties.

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

* Fixes according to review comments

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

* Update bundles/org.openhab.binding.mystrom/README.md

Co-authored-by: J-N-K <J-N-K@users.noreply.github.com>

* Fixes according to review comments

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

* Use system color temperature channel type

channel type system.color-temperature is used and values mapped from 1-18 to 0-100%

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

* Better tracking of colour and brightness values

Format power state
Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

Co-authored-by: J-N-K <J-N-K@users.noreply.github.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@Fredo70 @J-N-K
[mystrom] Add support for myStrom Bulb (openhab#9910)
4f8a359 
* Add support to myStrom Bulb

Add properties to myStrom devices and an action to refresh the properties.

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

* Fixes according to review comments

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

* Update bundles/org.openhab.binding.mystrom/README.md

Co-authored-by: J-N-K <J-N-K@users.noreply.github.com>

* Fixes according to review comments

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

* Use system color temperature channel type

channel type system.color-temperature is used and values mapped from 1-18 to 0-100%

Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

* Better tracking of colour and brightness values

Format power state
Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>

Co-authored-by: J-N-K <J-N-K@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

@pail23 pail23 pail23 approved these changes

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

[mystrom] contribution, add support for myStrom bulb
6 participants
@Fredo70 @J-N-K @fwolter @kaikreuzer @pail23 @Hilbrand