Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[homekit] mapping configuration improvements #9932

Merged
merged 4 commits into from Feb 4, 2021
Merged

[homekit] mapping configuration improvements #9932

merged 4 commits into from Feb 4, 2021

Conversation

yfre
Copy link
Contributor

@yfre yfre commented Jan 24, 2021

this PR adds following:

  • support for current and target mode mapping for thermostat
  • support for reduction of thermostat, security system and cooler/heater modes as requested in [homekit] Add configuration options to Security System #9482. e.g. it makes it possible to remove "Cool" mode from thermostat that does not support cooling.
  • additional logging on create&store pairing user (method createUser). Some users have reported issues with pairing configuration. Additional logging will help to troubleshoot these issues.

Eugen Freiter added 2 commits January 24, 2021 01:07
add support for custom mapping
5caa9b9 
Signed-off-by: Eugen Freiter <freiter@gmx.de>
add screenshot
d820dda 
Signed-off-by: Eugen Freiter <freiter@gmx.de>
@yfre yfre added the enhancement An enhancement or new feature for an existing add-on label Jan 24, 2021
@yfre yfre linked an issue Jan 24, 2021 that may be closed by this pull request
[homekit] Add configuration options to Security System #9482
Closed
Eugen Freiter added 2 commits January 25, 2021 11:16
remove unnecessary variable
fcb8969 
Signed-off-by: Eugen Freiter <freiter@gmx.de>
make parameter nullable to avoid not required list instances
d454070 
Signed-off-by: Eugen Freiter <freiter@gmx.de>
@yfre yfre added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 28, 2021
cpmeister
cpmeister approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yfre yfre requested a review from J-N-K February 2, 2021 08:27
@cpmeister cpmeister merged commit bd94951 into openhab:main Feb 4, 2021
@cpmeister cpmeister added this to the 3.1 milestone Feb 4, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
@yfre @themillhousegroup
[homekit] mapping configuration improvements (openhab#9932)
ae162be 
* add support for custom mapping
* add screenshot
* remove unnecessary variable
* make parameter nullable to avoid not required list instances

Signed-off-by: Eugen Freiter <freiter@gmx.de>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@yfre @thinkingstone
[homekit] mapping configuration improvements (openhab#9932)
b90f27b 
* add support for custom mapping
* add screenshot
* remove unnecessary variable
* make parameter nullable to avoid not required list instances

Signed-off-by: Eugen Freiter <freiter@gmx.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@yfre
[homekit] mapping configuration improvements (openhab#9932)
60343ac 
* add support for custom mapping
* add screenshot
* remove unnecessary variable
* make parameter nullable to avoid not required list instances

Signed-off-by: Eugen Freiter <freiter@gmx.de>
@yfre yfre deleted the 9482_custom_mapping branch November 15, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

@J-N-K J-N-K Awaiting requested review from J-N-K

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

[homekit] Add configuration options to Security System
2 participants
@yfre @cpmeister