Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tivo] fix bugs with standby mode and channel parsing #9964

Merged
merged 2 commits into from
Jan 26, 2021
Merged

[tivo] fix bugs with standby mode and channel parsing #9964

merged 2 commits into from
Jan 26, 2021

Conversation

mlobstein
Copy link
Contributor

This PR fixes 3 bugs with the tivo binding:

  1. Channel parsing fails for non-OTA channels
  2. The thing status is OFFLINE if openHAB is started while the Tivo is running a streaming app or is in standby mode
  3. Waking the device from standby mode does not work

Some minor documentation updates were also included.

Thanks to @AndyXMB for finding these issues.

@mlobstein
fix some tivo binding bugs
5981e1b 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein
update search example rule
d728aa8 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@fwolter fwolter merged commit a49b348 into openhab:main Jan 26, 2021
@fwolter fwolter added this to the 3.1 milestone Jan 26, 2021
@fwolter fwolter added the bug An unexpected problem or unintended behavior of an add-on label Jan 26, 2021
@mlobstein mlobstein mentioned this pull request Jan 30, 2021
Merged
@mlobstein mlobstein deleted the tivo_fix branch January 30, 2021 22:02
lsiepel added a commit to lsiepel/openhab-addons that referenced this pull request Feb 9, 2021
@lsiepel
Revert "[tivo] fix bugs with standby mode and channel parsing (openha…
1951fff 
…b#9964)"

This reverts commit a49b348.
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
@mlobstein @themillhousegroup
[tivo] fix bugs with standby mode and channel parsing (openhab#9964)
916ab7d 
* fix some tivo binding bugs

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>

* update search example rule

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@mlobstein @thinkingstone
[tivo] fix bugs with standby mode and channel parsing (openhab#9964)
a243289 
* fix some tivo binding bugs

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>

* update search example rule

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@mlobstein
[tivo] fix bugs with standby mode and channel parsing (openhab#9964)
c871745 
* fix some tivo binding bugs

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>

* update search example rule

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwolter fwolter fwolter approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mlobstein @fwolter