[openthermgateway] fix automatic reconnect after connection attempt fails #9965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com>
Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com>
fwolter
requested changes
Jan 26, 2021
| }, conf.connectionRetryInterval, TimeUnit.SECONDS); | ||
| if (!explicitDisconnect && conf != null && conf.connectionRetryInterval > 0) { | ||
| logger.debug("Scheduling to reconnect in {} seconds.", conf.connectionRetryInterval); | ||
| scheduler.schedule(this::connect, conf.connectionRetryInterval, TimeUnit.SECONDS); |
There was a problem hiding this comment.
A binding must not execute any task if it has been disposed. So, this task needs to be cancelled in dispose().
There was a problem hiding this comment.
Added cancelling task on dispose
Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/opentherm-gateway-binding/39160/204 |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/opentherm-gateway-binding/39160/206 |
lsiepel
added a commit
to lsiepel/openhab-addons
that referenced
this pull request
Feb 9, 2021
…ttempt fails (openhab#9965)" This reverts commit 5a7be93.
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
…ails (openhab#9965) * Added callback to disconnected() when connection attempt fails Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com> * Updated version number Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com> * Cancel reconnect task when disposing Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…ails (openhab#9965) * Added callback to disconnected() when connection attempt fails Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com> * Updated version number Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com> * Cancel reconnect task when disposing Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…ails (openhab#9965) * Added callback to disconnected() when connection attempt fails Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com> * Updated version number Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com> * Cancel reconnect task when disposing Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9903
Also see previously closed PR #9925
Signed-off-by: Arjen Korevaar a.korevaar@mephix.com