Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pidcontroller] Reset command Item; Fix read-only states of config parameters #9992

Merged
merged 2 commits into from Jan 31, 2021

Conversation

fwolter
Copy link
Member

@fwolter fwolter commented Jan 30, 2021

No description provided.

…ocessed

Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
@fwolter fwolter added the bug An unexpected problem or unintended behavior of an add-on label Jan 30, 2021
@fwolter fwolter requested a review from a team January 30, 2021 10:54
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hilbrand Hilbrand merged commit fd1caea into openhab:main Jan 31, 2021
@Hilbrand Hilbrand added this to the 3.1 milestone Jan 31, 2021
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Feb 23, 2021
…rameters (openhab#9992)

* [pidcontroller] Reset state of command Item after command has been processed
* Fix read-only state of item parameters

Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
@fwolter fwolter deleted the pid-cmd-reset branch April 11, 2021 18:10
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
…rameters (openhab#9992)

* [pidcontroller] Reset state of command Item after command has been processed
* Fix read-only state of item parameters

Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
…rameters (openhab#9992)

* [pidcontroller] Reset state of command Item after command has been processed
* Fix read-only state of item parameters

Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
…rameters (openhab#9992)

* [pidcontroller] Reset state of command Item after command has been processed
* Fix read-only state of item parameters

Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants