Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ringtone selector not themed #658

Closed
mueller-ma opened this issue Jan 20, 2018 · 2 comments
Closed

Ringtone selector not themed #658

mueller-ma opened this issue Jan 20, 2018 · 2 comments
Labels
bug Indicates an unexpected problem or unintended behavior wontfix Indicates that work won't continue on an issue or pull request

Comments

@mueller-ma
Copy link
Member

Since this is a system dialog, I'm not sure if we can theme it.

Lineageos 14.1

@mueller-ma mueller-ma added the bug Indicates an unexpected problem or unintended behavior label Jan 20, 2018
@FlorianSW
Copy link
Member

It seems, from a quick look, that this is a built-in preference, which can not be touched in any way by us. We could probably re-implement it's funtionality (it's a list of media files), however, the action of RingtonePreference could be finished by any other app/file manager, too, so I don't think we should do something like that. In my opinion, having this unthemed component there is the better solution? :)

@mueller-ma
Copy link
Member Author

That's also what I tought, I just wanted to hear someones opinion on that.

@mueller-ma mueller-ma added the wontfix Indicates that work won't continue on an issue or pull request label Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior wontfix Indicates that work won't continue on an issue or pull request
Projects
None yet
Development

No branches or pull requests

2 participants