openHAB add-ons are not shown as installed anymore

[cweitkamp]

Beside openHAB add-ons I am using a third-party JSON add-on provider. After a restart of my system all openHAB add-ons are not listed as installed anymore - all things are working properly - whereas all the third-party add-ons are listed correctly.

Extract of REST API response of endpoint addons/<ADDONID> looks like this

{
  "id": "binding-avmfritz",
  "label": "AVM FRITZ!Box Binding",
  "version": "3.3.0",
  "compatible": true,
  "contentType": "application/vnd.openhab.feature;type=karaf",
  "link": "https://www.openhab.org/addons/bindings/avmfritz/",
  "author": "openHAB",
  "verifiedAuthor": true,
  "installed": false,
  "type": "binding",
  "configDescriptionURI": "",
  "keywords": "",
  "countries": "",
  "connection": "",
  "properties": {},
  "loggerPackages": [
    "org.openhab.binding.avmfritz"
  ]
}

After removal of an openHAB add-on e.g. via REST API or console and reinstallation the state of all add-ons is shown correctly again.

[J-N-K]

Interesting. I don't see that.

In the KarafAddonService the list of add-ons is created by iterating over all features and calling getAddon. That uses the featureService to determine if an add-on is installed. Can you check in the karaf console if the features are listed as installed?

[cweitkamp]

It looks like the problem is only present after an upgrade - probably related to clearing the cache. After the afore mentioned workaround the listing is correct.

After an upgrade the feature is listed as Uninstalled whereas the bundle is Active:

openhab> bundle:list | grep -i avm
249 │ Active │  80 │ 3.4.0.202207040331     │ openHAB Add-ons :: Bundles :: AVM FRITZ! Binding
openhab> feature:list | grep -i avm                                                                                                                                                   
openhab-binding-avmfritz                          │ 3.4.0.SNAPSHOT   │          │ Uninstalled │ openhab-addons-3.4.0-SNAPSHOT                        │ AVM FRITZ!Box Binding
openhab> 

But as you can see the feature has a different version than the bundle.

[J-N-K]

Then there are two questions:

• Why are the old bundles still present after the cache was cleared?
• Why was the feature not installed?

It's easy to explain why it is working after you installed another add-on: Then the configuration changes, and the FeatureInstaller checks for all add-ons if the feature is installed or not and install it if it's missing.

On initial startup this seems to be not working properly. Could it be that the feature is still listed as installed and therefore the FeatureInstaller is not adding it? We don't check the version of the feature, so every feature with the correct name matches.

[jlaur]

I have had the same issue after each 3.3 milestone upgrade (as well as final version), where I uninstalled a random binding and installed it again, after which all bindings started working again. I was assuming something was wrong with my setup since I didn't see anyone mention this. Unfortunately my logs from last upgrade are lost now, but I remember seeing some error with a list of bundles mentioned in the logs during the upgrade.

[J-N-K]

I just upgraded to latest snapshot and saw the same effect. At next restart using remote debugging all add-ons were properly installed. Do you see the same? An additional restart solves the issue? Otherwise it might be timing related.

[jlaur]

@J-N-K - I just now missed the chance to verify if a reboot would have solved it. :-/ But it happened again with 3.4M1, and this time I got the log message:
2022-08-13 00:02:51.065 [ERROR] [core.karaf.internal.FeatureInstaller] - Failed installing 'openhab-binding-hue, openhab-automation-pidcontroller, openhab-binding-deconz, openhab-binding-nest, openhab-binding-pushover, openhab-binding-network, openhab-ui-habpanel, openhab-automation-jsscripting, openhab-binding-harmonyhub, openhab-binding-mqtt, openhab-transformation-map, openhab-binding-lgwebos, openhab-binding-kodi, openhab-binding-oppo, openhab-persistence-jdbc-mysql, openhab-binding-irobot, openhab-binding-danfossairunit, openhab-binding-mielecloud, openhab-transformation-javascript, openhab-binding-sonos, openhab-persistence-rrd4j, openhab-ui-basic, openhab-binding-astro, openhab-binding-pushbullet, openhab-binding-unifi, openhab-binding-squeezebox': Permission denied

[J-N-K]

I believe this will be solved by #3049.