-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alternative utility class for apache subnetutils #3965
Comments
I don't think that's necessary. We need |
Oké, in that case I think openhab/openhab-addons#7722 can be closed, as these are the last dependencies in addons repo. @wborn wdyt? |
Maybe you can use |
This issue is not about removing commons-net at this moment, its scope is much smaller. It is about reducing some dependencies to commons-net. I know we still depend on commons-net due to nrjavaserial, but why not reduce it as much as possible? I also see this as an opportunity to reduce and improve code that is used in multiple bindings that have about the same functionality. For instance, when i do a quick scan, it looks like none of the 5 involved bindings respect the openHAB "Network Configuration" settings. |
Yes that might be a nice improvement to fix multiple issues at once. 👍 |
We try to get rid of dependencies to apache libs per openhab/openhab-addons#7722
we made great progress with #3738
Now there are 5 bindings that make use of subnetutils. I suggest a similar approach here, I can create an alternative util class in core to prevent code duplication. will be based on openhab/openhab-addons#14430 (comment) where the implementation was confirmed working as expected.
@openhab/core-maintainers any thoughts before I start working on it?
The text was updated successfully, but these errors were encountered: