-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thing File based configuration not loaded correctly after changing #4201
Comments
As I understand, you only change the thing label. And what is your running OH version ? |
@lolodomo yes, for any binding/thing you do ..it doesn't matter if you only change the label or the settings of the thing....so just a change...also item files I see this behavior.... I recognized this behavior in OH4.2M2 OH4.2M2 on latest openhabian release |
I am able to reproduce. We can change several times the thing label and it is properly updated. The problem is only when you try to restore the initial value. This change is apparently ignored even if the logs show that the file is reloaded. |
I haven't tested this scenario specifically. Without tracing it at runtime, I "suspect" this is what's happening:
#4076 should fix this issue |
Ok, I will test again once #4076 is merged. |
#4076 is merged |
Yes it's merged, but it hasn't yet made it into the latest snapshot. Hopefully within the next 12 hours! |
Is it possible to update the issue title to precise that it concerns Thing files ? |
@lolodomo better title now? |
I can't seem to reproduce this issue. Can you tell me the steps to reproduce it? Here's what I did:
|
My scenario was:
Tested on RPI. The file is on the SD card (so not a network share) and edited using vi. |
I'm still not able to reproduce the problem. I tried your things file verbatim (including
But upon changing the label, it did get updated on the Main UI (I had to refresh the browser). I then tried entering an actual coordinate in the .things file:
Stopped openhab |
Of course, I do not use "xxxx" as geolocation, it was just to not provide a real position. If you are sure it works, I will try again. |
My server was restarted yesterday. This morning, I tried again and I reproduced the problem. The first change of thing label is not applied even if the change of file is detected. Next changes are fine, even returning to the original thing label. |
@lolodomo can confirm same behaviour as before I am on I changed the file shelly.things from to
in the log I see But still the old description in the UI I stopped openhab started new now it was changed....tried it 2 times the same scenario....means only new loaded with a restart |
Is it only at the first change or at any next change ? Please note that the list of things in Main UI is not automatically updated, you have to refresh it. |
Only first change |
Well, we have the same result. @jimtng : that is strange that you can't reproduce it. |
Can I log it somehow more? |
I was testing it on snapshot build 4064 and couldn't replicate the problem.
|
I think there's still a bug. I'm now able to reproduce this under a different set of conditions. Looking into it more! |
The Bug I found was this:
However, I still haven't been able to reproduce the problem when the .things file only contain things from the same binding. In any case, could you please test this jar file? You will need to clear openhab cache and tmp dirs. Note I had to add a fake .zip extension. This is not a zip file. Just rename and remove the .zip extension and do not unzip it. org.openhab.core.model.thing-4.2.0-SNAPSHOT.jar.zip This file needs to be placed inside |
@jimtng Which one do I need to replace?
|
In the meantime I tested also other thing files....the first time it's not changing but than it seems to be fine |
The one with the exact same name. |
the second one is just a link :) so I have only one.....I used |
@jimtng looks good for me.....now I am on openHAB 4.2.0 (Build #4065) with the jar file replaced as @jimtng wrote I changed the file shelly.things from
already on the first attemp changed back from
|
@lolodomo would you mind testing too please |
@miloit thanks for testing. I take it that the jar I supplied did fix the problem? Would you mind testing the following:
It should log that only the changed thing would go offline -> online and the unchanged thing should remain online. |
@jimtng Yes the jar file fixed the problem Also the second situation is running fine for me.... |
This issue has been mentioned on openHAB Community. There might be relevant details there: |
Hello,
I changed the thing file
from
to
this is the log
than change it back to
seeing this in the log
but this in the ui
No update was loaded
The text was updated successfully, but these errors were encountered: