Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karaf 4.0.8 should be tested #18

Closed
maggu2810 opened this issue Jan 5, 2016 · 35 comments
Closed

Karaf 4.0.8 should be tested #18

maggu2810 opened this issue Jan 5, 2016 · 35 comments

Comments

@maggu2810
Copy link
Contributor

maggu2810 commented Jan 5, 2016

Jean-Baptiste Onofré, 08:48
...
Today I'm fixing the latest Jira for 4.0.4, I should be able to submit 4.0.4 release to vote tomorrow

We should test K404 as soon as its voting round starts and we should vote +1 (if all is fine) or -1 (is something is broked) for the release.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@maggu2810
Copy link
Contributor Author

FYI: the vote has been started
http://karaf.922171.n3.nabble.com/VOTE-Apache-Karaf-4-0-4-release-tp4044726.html
After the release freeze we should test this immediately to guarantee that we have no regressions using K404 for the next developmemt round.

@maggu2810
Copy link
Contributor Author

@kaikreuzer
Copy link
Member

I just had a first try (see https://github.com/kaikreuzer/openhab-distro/tree/karaf404)
Build works fine, but the offline-distro does not start:

2016-01-16 01:07:00.038 [WARN ] [url.mvn.internal.AetherBasedResolver] - Error resolving artifactorg.ops4j.pax.web:pax-web-jetty:jar:4.2.4:Could not find artifact org.ops4j.pax.web:pax-web-jetty:jar:4.2.4
shaded.org.eclipse.aether.resolution.ArtifactResolutionException: Could not find artifact org.ops4j.pax.web:pax-web-jetty:jar:4.2.4
        at shaded.org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:444)[4:org.ops4j.pax.url.mvn:2.4.5]
        at shaded.org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:246)[4:org.ops4j.pax.url.mvn:2.4.5]
        at shaded.org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact(DefaultArtifactResolver.java:223)[4:org.ops4j.pax.url.mvn:2.4.5]
        at shaded.org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact(DefaultRepositorySystem.java:294)[4:org.ops4j.pax.url.mvn:2.4.5]

It seems as if we need to update some other versions with it.
@dvanherbergen Can you help on that?

@dvanherbergen
Copy link
Contributor

We'll need to add a patched version of pax-web-jetty 4.2.4. I will have a look later today.

@kaikreuzer
Copy link
Member

We'll need to add a patched version of pax-web-jetty 4.2.4. I will have a look later today.

Did you prepare such a patched version?

@dvanherbergen
Copy link
Contributor

Yes, but I was having some issues getting it deployed correctly to bintray. Do you happen to have the correct command to use?

@kaikreuzer
Copy link
Member

You mean

curl -T <FILE.EXT> -u<USER>:<API_KEY> https://api.bintray.com/content/openhab/mvn/openhab-distro-deps/<VERSION>/<FILE_TARGET_PATH>

or better directly through Maven deploy with

<distributionManagement>
    <repository>
        <id>bintray-openhab-mvn</id>
        <name>openhab-mvn</name>
        <url>https://api.bintray.com/maven/openhab/mvn/openhab-distro-deps/;publish=1</url>
    </repository>
</distributionManagement>

?

@dvanherbergen
Copy link
Contributor

It's the maven deploy that was causing trouble for me. I got it to work now after throwing out the nexus-staging-maven-plugin, which was interfering with a regular deploy.

The jar is available now on bintray as

    <groupId>org.openhab.distro.deps</groupId>
    <artifactId>pax-web-jetty</artifactId>
    <version>4.2.4.sp1</version>

@dvanherbergen
Copy link
Contributor

I will do a test with an updated pom + descriptor. If the offline distro starts, I'll create a PR.

@maggu2810
Copy link
Contributor Author

Apr 01, 2016; 3:23am: [VOTE] Apache Karaf 4.0.5 release
http://karaf.922171.n3.nabble.com/VOTE-Apache-Karaf-4-0-5-release-td4046085.html

@kaikreuzer kaikreuzer changed the title Karaf 4.0.4 should be tested Karaf 4.0.5 should be tested Apr 4, 2016
@kaikreuzer
Copy link
Member

I have updated the title accordingly - it imho makes no sense to go to 4.0.4 anymore.

@maggu2810
Copy link
Contributor Author

The jar is available now on bintray as

    <groupId>org.openhab.distro.deps</groupId>
    <artifactId>pax-web-jetty</artifactId>
    <version>4.2.4.sp1</version>

@dvanherbergen Cannot find it. Could you point me to?

@dvanherbergen
Copy link
Contributor

oops, my bad. The version is slightly different. You can find it here

<dependency>
  <groupId>org.openhab.distro.deps</groupId>
  <artifactId>pax-web-jetty</artifactId>
  <version>4.2.4</version>
</dependency>

@maggu2810
Copy link
Contributor Author

@dvanherbergen Thanks!
Do you know the issue about the console (keyboard input corrupt, double openHAB logo)? I don't find it ATM.

@dvanherbergen
Copy link
Contributor

Yes, it happens when you start using the start.sh script. Then the logo appears twice (with version 4.0.4) only. It has been some time since I tested, this so I'm not sure if it is still there. Potentially this could have been resolved if one of the dependencies has been changed.

@maggu2810
Copy link
Contributor Author

I used the openhab stuff yesterday to create some PRs.
After I tested my changes, I see this error myself.
I bumped Karaf from 4.0.3 to 4.0.4 and the error has gone.
Are you sure you have seen this with Karaf 4.0.4 and not with Karaf 4.0.3?
IIRC there has been a separate issue for this problem (but perhaps I am wrong, did not found them) and I want to report there that it could be solved after using a more recent Karaf (hopefully 4.0.5 soon).

@dvanherbergen
Copy link
Contributor

I believe it was 4.0.4, but I will retest to confirm.

@kaikreuzer kaikreuzer changed the title Karaf 4.0.5 should be tested Karaf 4.0.6 should be tested Aug 30, 2016
@kaikreuzer
Copy link
Member

I updated the title to 4.0.6, which had just been released.

@kaikreuzer
Copy link
Member

@dvanherbergen For Karaf 4.0.6, we now need a patched org.ops4j.pax.web:pax-web-jetty:jar:4.2.8. It is a bit awkward having to ask you every time for a patched version; but I also do not have the details on how you patched it...
Could you come up with an easy script that does the necessary changes, so that we could more or less do this automatically? Or what is the best way to proceed here for easy Karaf upgrades?

@dvanherbergen
Copy link
Contributor

I'll have a look...

On 04 Sep 2016, at 21:21, Kai Kreuzer notifications@github.com wrote:

@dvanherbergen For Karaf 4.0.6, we now need a patched org.ops4j.pax.web:pax-web-jetty:jar:4.2.8. It is a bit awkward having to ask you every time for a patched version; but I also do not have the details on how you patched it...
Could you come up with an easy script that does the necessary changes, so that we could more or less do this automatically? Or what is the best way to proceed here for easy Karaf upgrades?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@maggu2810
Copy link
Contributor Author

No need to test K406 and K407 if you need a working shell.

@kaikreuzer
Copy link
Member

Why? Could you link the issue?

@maggu2810
Copy link
Contributor Author

@kaikreuzer
Copy link
Member

:-( Seems we are the only ones using it on ARM...
But I would hope that this issue gets addressed before 4.0.7 is final.

@dvanherbergen
Copy link
Contributor

Could you come up with an easy script that does the necessary changes, so that we could more or less do this automatically? Or what is the best way to proceed here for easy Karaf upgrades?

I've finally found some time to look into this. Pull request #285 automates the patch as part of the build. It should work with any version of pax-web as long as the method signature of org.ops4j.pax.web.utils.ClassPathUtil.findResources doesn't change. Looking at the history of that file, it hasn't changed much in the last years, so I think that should be OK.

The patch automation itself is done using a small utility jar that performs byte code manipulation. You can find that jar here: https://github.com/dvanherbergen/openhab-util. I've also deployed it to bintray so that it can be used in the build.

@kaikreuzer
Copy link
Member

Hi Davy, This is pretty cool, many thanks! This should make it much easier for us in future to do Karaf upgrades. We now just have to find a new Karaf version that hasn't any major flaws ;-)

@kaikreuzer kaikreuzer changed the title Karaf 4.0.6 should be tested Karaf 4.0.7 should be tested Sep 25, 2016
@maggu2810
Copy link
Contributor Author

Interesting approach. 👍

@kaikreuzer kaikreuzer changed the title Karaf 4.0.7 should be tested Karaf 4.0.8 should be tested Oct 13, 2016
@kaikreuzer
Copy link
Member

FTR: https://issues.apache.org/jira/browse/KARAF-4714 is only fixed in 4.0.8, so we have to wait for this to be released.
@maggu2810 Did you by any chance already verify that 4.0.8 correctly works again?

@maggu2810
Copy link
Contributor Author

It is not solved for me.

@kaikreuzer
Copy link
Member

:-(
But many thanks for testing!

@maggu2810
Copy link
Contributor Author

I will keep you informed if the console problem is solved in general (at least on my ARM systems).

@kaikreuzer
Copy link
Member

FTR: I am working on the Karf 4.0.8 upgrade and it looks quite good so far. A few small issues still to solve, though.

@maggu2810
Copy link
Contributor Author

A few small issues still to solve, though.

Can you give me some details?

@maggu2810
Copy link
Contributor Author

maggu2810 commented Dec 21, 2016

Do you refer to openhab/openhab-core#99?

@kaikreuzer
Copy link
Member

Actually only to this single line. I hadn't changed this in my first tests and that resulted in having two Karaf shells being active in parallel - not a nice experience ;-

The rest works pretty smooth!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants