-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Karaf 4.0.8 should be tested #18
Comments
FYI: the vote has been started |
K404 has been released: |
I just had a first try (see https://github.com/kaikreuzer/openhab-distro/tree/karaf404)
It seems as if we need to update some other versions with it. |
We'll need to add a patched version of pax-web-jetty 4.2.4. I will have a look later today. |
Did you prepare such a patched version? |
Yes, but I was having some issues getting it deployed correctly to bintray. Do you happen to have the correct command to use? |
You mean
or better directly through Maven deploy with
? |
It's the maven deploy that was causing trouble for me. I got it to work now after throwing out the nexus-staging-maven-plugin, which was interfering with a regular deploy. The jar is available now on bintray as
|
I will do a test with an updated pom + descriptor. If the offline distro starts, I'll create a PR. |
Apr 01, 2016; 3:23am: [VOTE] Apache Karaf 4.0.5 release |
I have updated the title accordingly - it imho makes no sense to go to 4.0.4 anymore. |
@dvanherbergen Cannot find it. Could you point me to? |
oops, my bad. The version is slightly different. You can find it here
|
@dvanherbergen Thanks! |
Yes, it happens when you start using the start.sh script. Then the logo appears twice (with version 4.0.4) only. It has been some time since I tested, this so I'm not sure if it is still there. Potentially this could have been resolved if one of the dependencies has been changed. |
I used the openhab stuff yesterday to create some PRs. |
I believe it was 4.0.4, but I will retest to confirm. |
I updated the title to 4.0.6, which had just been released. |
@dvanherbergen For Karaf 4.0.6, we now need a patched org.ops4j.pax.web:pax-web-jetty:jar:4.2.8. It is a bit awkward having to ask you every time for a patched version; but I also do not have the details on how you patched it... |
I'll have a look...
|
No need to test K406 and K407 if you need a working shell. |
Why? Could you link the issue? |
:-( Seems we are the only ones using it on ARM... |
I've finally found some time to look into this. Pull request #285 automates the patch as part of the build. It should work with any version of pax-web as long as the method signature of org.ops4j.pax.web.utils.ClassPathUtil.findResources doesn't change. Looking at the history of that file, it hasn't changed much in the last years, so I think that should be OK. The patch automation itself is done using a small utility jar that performs byte code manipulation. You can find that jar here: https://github.com/dvanherbergen/openhab-util. I've also deployed it to bintray so that it can be used in the build. |
Hi Davy, This is pretty cool, many thanks! This should make it much easier for us in future to do Karaf upgrades. We now just have to find a new Karaf version that hasn't any major flaws ;-) |
Interesting approach. 👍 |
FTR: https://issues.apache.org/jira/browse/KARAF-4714 is only fixed in 4.0.8, so we have to wait for this to be released. |
It is not solved for me. |
:-( |
I will keep you informed if the console problem is solved in general (at least on my ARM systems). |
FTR: I am working on the Karf 4.0.8 upgrade and it looks quite good so far. A few small issues still to solve, though. |
Can you give me some details? |
Do you refer to openhab/openhab-core#99? |
Actually only to this single line. I hadn't changed this in my first tests and that resulted in having two Karaf shells being active in parallel - not a nice experience ;- The rest works pretty smooth! |
We should test K404 as soon as its voting round starts and we should vote +1 (if all is fine) or -1 (is something is broked) for the release.
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: