We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The backup script doesn't escape some environment variables when invoked without arguments. See https://community.openhab.org/t/backup-restore-scripts-for-linux-and-macos/34491/44?u=shutterfreak
Offending code:
echo "Set $OPENHAB_BACKUPS to change the default backup directory." echo "Set $OPENHAB_BACKUPS_TEMP to change the default backup temporary directory."
Suggested fix:
echo "Default backup directory: '$OPENHAB_BACKUPS'" echo "Set \$OPENHAB_BACKUPS to change the default backup directory." echo "Default backup temporary directory: '$OPENHAB_BACKUPS_TEMP'" echo "Set \$OPENHAB_BACKUPS_TEMP to change the default backup temporary directory."
I'd also add that the backup script must be run as root (can be checked with $UID (0 for root) when the script is run without arguments.
$UID
The text was updated successfully, but these errors were encountered:
Escape environment variables and display current value
91232d8
Fixes openhab#894
Can't get to comply with DCO checks in my PR though.
Sorry, something went wrong.
Escape environment variables and display current value (#1018)
60a164f
Fixes #894
Successfully merging a pull request may close this issue.
The backup script doesn't escape some environment variables when invoked without arguments. See https://community.openhab.org/t/backup-restore-scripts-for-linux-and-macos/34491/44?u=shutterfreak
Offending code:
Suggested fix:
I'd also add that the backup script must be run as root (can be checked with
$UID
(0 for root) when the script is run without arguments.The text was updated successfully, but these errors were encountered: