Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate long filename issues on Windows backup-script #1353

Merged
merged 1 commit into from Dec 28, 2021

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Dec 18, 2021

Related to #1087

This does not solve the full issue (which is inherent to Windows insisting on the max path length of 260 characters even if NTFS is capable of 65k characters) but it at least mitigates the issue for backups if the long filenames are in tmp, cache or backup (which I believe is the most common situation).

@J-N-K J-N-K requested a review from a team as a code owner December 18, 2021 21:02
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/windows-install-script-fails-due-to-long-pathname/130429/1

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit 6593807 into openhab:main Dec 28, 2021
@wborn wborn added this to the 3.3 milestone Dec 28, 2021
@wborn wborn added the bug An unexpected problem or unintended behavior label Dec 28, 2021
@wborn wborn changed the title mitigate long filename issues on Windows backup-script Mitigate long filename issues on Windows backup-script Dec 28, 2021
@J-N-K J-N-K deleted the backup branch December 28, 2021 13:57
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/update-ps1-script-failed-windows-10/131554/16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants