Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger configuration for ItemStateUpdatedEvent & GroupStateUpdatedEvent #1515

Merged
merged 2 commits into from Apr 4, 2023

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Apr 4, 2023

Refs openhab/openhab-core#3141.

The newly added ItemStateUpdated & GroupStateUpdatedEvents are flooding my event logs and are not „hidden“ like other updated events, this adds the required logger configuration.

Refs openhab/openhab-core#3141.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner April 4, 2023 08:05
@J-N-K
Copy link
Member

J-N-K commented Apr 4, 2023

Maybe the same applies to GroupStateUpdatedEvent?

@florian-h05
Copy link
Contributor Author

Indeed yes, thanks for the hint.

Refs openhab/openhab-core#3141.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 changed the title Add logger configuration for ItemStateUpdatedEvent Add logger configuration for ItemStateUpdatedEvent & GroupStateUpdatedEvent Apr 4, 2023
@J-N-K J-N-K merged commit 0b0792f into openhab:main Apr 4, 2023
3 checks passed
@J-N-K J-N-K added this to the 4.0 milestone Apr 4, 2023
@J-N-K J-N-K added the enhancement An enhancement or new feature label Apr 4, 2023
@florian-h05 florian-h05 deleted the patch-2 branch April 4, 2023 08:40
@florian-h05 florian-h05 restored the patch-2 branch April 4, 2023 08:40
@florian-h05 florian-h05 deleted the patch-2 branch April 4, 2023 08:40
@florian-h05 florian-h05 restored the patch-2 branch April 4, 2023 08:40
@florian-h05 florian-h05 deleted the patch-2 branch April 4, 2023 08:40
@wborn
Copy link
Member

wborn commented Apr 4, 2023

You probably also want to update distributions/openhab/src/main/resources/userdata/etc/log4j2.xml because the file that you modified in this PR is only used when running openHAB with Eclipse.

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-0-snapshot-discussion/142322/297

@rkoshak
Copy link
Contributor

rkoshak commented Apr 4, 2023

I created a PR for the other file: #1517

@florian-h05
Copy link
Contributor Author

@rkoshak Thx for taking that over. I wasn’t in reach of my system to open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants