Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hue] Add update note about light channels #1612

Merged
merged 1 commit into from
Dec 5, 2023
Merged

[hue] Add update note about light channels #1612

merged 1 commit into from
Dec 5, 2023

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Dec 5, 2023

@jlaur
Add update note about light channels
89c59a8 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur requested a review from a team as a code owner December 5, 2023 21:14
@kaikreuzer
Copy link
Member

Our thing migration framework does not work in this case?

@jlaur
Copy link
Contributor Author

jlaur commented Dec 5, 2023

Our thing migration framework does not work in this case?

No, I tested it with both update-channel as well as remove-channel + add-channel without success. I had a quick look at the migration code, but it didn't seem obvious to me how to fix this. For now I mentioned it here: openhab/openhab-core#3660.

kaikreuzer
kaikreuzer approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alrght then, thanks!

@kaikreuzer kaikreuzer merged commit f1d8e38 into openhab:main Dec 5, 2023
3 checks passed
@jlaur jlaur deleted the hue-update-note branch December 5, 2023 21:26
@jlaur jlaur added this to the 4.1 milestone Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jlaur @kaikreuzer