Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suggestion finder parameters to addons.cfg #1633

Merged
merged 2 commits into from Feb 4, 2024

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented Feb 2, 2024

Some of the add-on suggestion finders can be disable through the UI, or parameters in the addons.cfg file.

In this PR, these parameters are added (commented) in the configuration file.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege mherwege requested a review from a team as a code owner February 2, 2024 14:34
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh-4-1-1-startup-takes-more-than-an-hour/153310/38

@andrewfg
Copy link
Contributor

andrewfg commented Feb 2, 2024

@mherwege to be correct, the file name is 'addon.config' (rather than 'addon.cfg').

EDIT: apparently the raw 'addon.cfg' is auto-magically transformed into 'addon.config' at run-time. ??

@mherwege
Copy link
Contributor Author

mherwege commented Feb 2, 2024

@mherwege to be correct, the file name is 'addon.config' (rather than 'addon.cfg')..

Please check again, it is addons.cfg in the services directory.

@mherwege mherwege changed the title Add suggestion finder parameters to addon.cfg Add suggestion finder parameters to addons.cfg Feb 2, 2024
@andrewfg
Copy link
Contributor

andrewfg commented Feb 2, 2024

Apparently the raw 'addon.cfg' in services is auto-magically transformed into 'addon.config' in userdata at run-time. ??

//OPENHABIAN/openHAB-conf/services/addon.cfg => //OPENHABIAN/openHAB-userdata/config/org/openhab/addon.config

@mherwege
Copy link
Contributor Author

mherwege commented Feb 2, 2024

Apparently the raw 'addon.cfg' in services is auto-magically transformed into 'addon.config' in userdata at run-time. ??

//OPENHABIAN/openHAB-conf/services/addon.cfg => //OPENHABIAN/openHAB-userdata/config/org/openhab/addon.config

Indeed, but it is addons.cfg, not addon.cfg (that was my mistake, but I updated the correct file).
It is a bit more complex than that, because userdata/config/org/openhab/addon.config will also contain the UI configured parameters.

@andrewfg
Copy link
Contributor

andrewfg commented Feb 2, 2024

a bit more complex than that, because userdata/config/org/openhab/addon.config will also contain the UI configured parameters

Yeah. What I observed was that if you change a finder config via the UI then addon.config is updated. And I think the other way round if you change addon.config manually then the UI reflects that. ?? But presumably if you change addon.cfg that overrides addon.config and makes the parameter effectively read only.

@wborn wborn added rebuild Triggers a new PR build and removed rebuild Triggers a new PR build labels Feb 4, 2024
Signed-off-by: Wouter Born <github@maindrain.net>
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit a9c0991 into openhab:main Feb 4, 2024
2 of 3 checks passed
@wborn wborn added this to the 4.2 milestone Feb 4, 2024
@wborn wborn added the enhancement An enhancement or new feature label Feb 4, 2024
@mherwege mherwege deleted the finders_config branch February 4, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants