Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved some system files away from userdata/etc #364

Merged
merged 1 commit into from Dec 31, 2016

Conversation

kaikreuzer
Copy link
Member

Signed-off-by: Kai Kreuzer kai@openhab.org

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@mention-bot
Copy link

@kaikreuzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @digitaldan and @dvanherbergen to be potential reviewers.

@BClark09
Copy link
Member

Just making sure, would you expect custom.properties, system.properties and org.ops4j.pax.web.cfg, to be changed by the user at any point? If not, you may want to add them to the list of files to be excluded and included later just as in PR #364.

@kaikreuzer
Copy link
Member Author

you may want to add them to the list of files to be excluded

@BClark09 What list do you mean exactly?
No, I consider many more files in userdata/etc as system files that should not be touched by the user - the ones you mention are such cases. Unfortunately, Karaf expects them in the etc folder and there is no easy way to move them out. I am still experimenting with some solutions for this.

This PR here just does some simple changes that work well, so I wanted to get that out asap, while working on the rest.

@BClark09
Copy link
Member

BClark09 commented Dec 31, 2016

Sorry I was speaking about the list of configuration files for the Debian packages. If anything has happened to the three files I mentioned above it might prompt the user to keep the existing files on the upgrade. I think it should be fine to merge and make a new PR later that does what I did in #358 for custom.properties, system.properties and org.ops4j.pax.web.cfg

EDIT: I realise I referenced the wrong PR number the first time...

@kaikreuzer
Copy link
Member Author

The files I moved are now in runtime and not userdata anymore, so they will anyhow be completely overwritten (and should never be touched by a user). As mentioned in #299 (comment), we should get towards a solution that is not Debian specific, so my goal is to really strictly separate system from user files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants