WIP: Update ZigBee feature to split bundles per dongle #649
Conversation
cdjackson
force-pushed
the
zigbee-split-bundles
branch
from
b07cc87
to
0cfc76a
Compare
| @@ -3,10 +3,13 @@ | |||
|
|
|||
| <!-- these are 2.x add-ons in separate repositories (which do not have their own Karaf feature defined), so we include them here --> | |||
|
|
|||
| <feature name="openhab-binding-zigbee" description="ZigBee Binding" version="${project.version}"> | |||
| <feature name=“openhab-binding-zigbee-ember" description="ZigBee Binding for Ember NCP" version="${project.version}"> | |||
There was a problem hiding this comment.
With respect to the Github diff view I assume the quote character in front of openHAB is not the one that has been expected.
|
Well spotted - thanks. The damn MacOS Xcode editor does this :(
… On 5 Mar 2018, at 18:45, Markus Rathgeb ***@***.***> wrote:
@maggu2810 commented on this pull request.
In features/addons/src/main/feature/feature.xml <#649 (comment)>:
> @@ -3,10 +3,13 @@
<!-- these are 2.x add-ons in separate repositories (which do not have their own Karaf feature defined), so we include them here -->
- <feature name="openhab-binding-zigbee" description="ZigBee Binding" version="${project.version}">
+ <feature name=“openhab-binding-zigbee-ember" description="ZigBee Binding for Ember NCP" version="${project.version}">
With respect to the Github diff view I assume the quote character in front of openHAB is not the one that has been expected.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#649 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA_kQ6OdPp2tuMSHSQIMXV_Mz9eai8nnks5tbYeXgaJpZM4Sa5uw>.
|
Signed-off-by: Chris Jackson <chris@cd-jackson.com>
cdjackson
force-pushed
the
zigbee-split-bundles
branch
from
0cfc76a
to
8827e87
Compare
| @@ -3,10 +3,13 @@ | |||
|
|
|||
| <!-- these are 2.x add-ons in separate repositories (which do not have their own Karaf feature defined), so we include them here --> | |||
|
|
|||
| <feature name="openhab-binding-zigbee" description="ZigBee Binding" version="${project.version}"> | |||
| <feature name="openhab-binding-zigbee-ember" description="ZigBee Binding for Ember NCP" version="${project.version}"> | |||
There was a problem hiding this comment.
Why did you rename this feature? My suggestion was to leave things as they are in the face of the user and just add all the different bundles in this feature.
There was a problem hiding this comment.
Ah - ok, I misunderstood. no problem, I can add all 4 - no problem.
| <feature>openhab-runtime-base</feature> | ||
| <feature>openhab-transport-serial</feature> | ||
| <bundle start-level="80">mvn:org.openhab.binding/org.openhab.binding.zigbee/${project.version}</bundle> | ||
| <bundle start-level="80">mvn:org.openhab.binding/org.openhab.binding.zigbee.ember/${project.version}</bundle> | ||
| <bundle start-level="80">mvn:com.zsmartsystems.zigbee/com.zsmartsystems.zigbee</bundle> |
There was a problem hiding this comment.
Hm, that won't really work - addons must not bring any external dependencies that are not part of the openhab base feature (or available in the TP of the IDE). It'll be better to continue to include them as a lib in the appropriate version, I guess.
There was a problem hiding this comment.
I thought as much, but hoped there might have been another setting somewhere to set the repo. I can look at adding the files to the JARs, or something similar, but I see you have other comments on the overall refactoring that we probably need to discuss further first ;)
|
Superseded by #676. |
As discussed here the new configuration for ZigBee bundles requires the features to be split.
I'm not sure if there's additional changes required - I could guess that the mvn location for the library artefacts need to be defined somewhere.
Please let me know if there's anything I need to add or change here. Once the structure is correct I'll also need to add the other dongles - at the moment I've just included a feature for the Ember dongle.
Clearly merging of this PR needs to be coordinated with the PR to split the bundles.
Signed-off-by: Chris Jackson chris@cd-jackson.com