Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added task to install compat layer when testing openHAB 1 add-ons #95

Merged
merged 1 commit into from Jan 18, 2016

Conversation

kaikreuzer
Copy link
Member

Signed-off-by: Kai Kreuzer kai@openhab.org

@maggu2810
Copy link
Contributor

You can remove one space between "-" and "A" (+ - As with).

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer
Copy link
Member Author

fixed.

maggu2810 added a commit that referenced this pull request Jan 18, 2016
added task to install compat layer when testing openHAB 1 add-ons
@maggu2810 maggu2810 merged commit 1240832 into openhab:master Jan 18, 2016
@kaikreuzer kaikreuzer deleted the doc branch January 18, 2016 10:26
@lolodomo
Copy link
Contributor

@kaikreuzer : JUst one little question: why the compat layer is not a bundle installed by default ?

@kaikreuzer
Copy link
Member Author

Why should it? If someone does not use any 1.x add-ons there is no need for it.
And once an add-on is added to the distro (see step 6 on https://github.com/openhab/openhab-distro/blob/master/docs/sources/features/compatibilitylayer.md), the compat layer is automatically installed when installing the add-on (so the user does not have to do that).

@lolodomo
Copy link
Contributor

If automatic, why mentioning to do it manually ?

@kaikreuzer
Copy link
Member Author

Because this is the documentation for developers on "How to use openHAB 1.x Add-ons that are not part of the distribution"

@maggu2810
Copy link
Contributor

@lolodomo If you install addons / bundles using features / extension management, the compat layer will be installed if necessary. As this dependencies are defined.
If you install bundles using the addons directory / file deployment, you have to ensure yourself that dependencies will be installed.

@lolodomo
Copy link
Contributor

That is clearer with this last explanation.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants