update version of com.zsmartsystems.zigbee to 1.2.3 #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Spero <sesuncedu@gmail.com>
sesuncedu
force-pushed
the
czz-version-bump
branch
from
c93686b
to
4175f53
Compare
wborn
approved these changes
Sep 28, 2019
|
Sorry @cweitkamp - I didn't see this until it was merged just now. I thought that one of the advantages of the new system with bnd is that all dependencies were now managed in one place (ie in the binding repository) and we didn't need to update these other files now? I assume I'm wrong with that? |
|
@cdjackson Yes, that is partly true. To archive that we have to move the feature file from this location into the https://github.com/openhab/org.openhab.binding.zigbee/ repository. Similar to what we did with other openHAB 2 add-ons (see https://github.com/openhab/openhab2-addons/pull/5555). |
|
Ok, thanks. Is there anything stopping us doing that? I could guess there might be something else required to consolidate all the feature files? Or is that already in place and we only need to move the file?
… On 28 Sep 2019, at 11:15, Christoph Weitkamp ***@***.***> wrote:
@cdjackson <https://github.com/cdjackson> Yes, that is partly true. To archive that we have to move the feature file from this location into the https://github.com/openhab/org.openhab.binding.zigbee/ <https://github.com/openhab/org.openhab.binding.zigbee/> repository. Similar to what we did with other openHAB 2 add-ons (see openhab/openhab2-addons#5555 <https://github.com/openhab/openhab2-addons/pull/5555>).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#972?email_source=notifications&email_token=AAH6IQZUVHO6QB6YDBOUZVLQL4VEDA5CNFSM4I2SPFLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD72VSVI#issuecomment-536172885>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAH6IQ7GV67UAUVT5HZDIYDQL4VEDANCNFSM4I2SPFLA>.
|
|
I can remember we talked about this some time ago (see openhab/org.openhab.binding.zigbee#454 (comment)) but to be honest I do not know if someone started working on it. |
|
Thanks, but this just says we should move the file into the Zigbee repo - is it just that simple, or is there something else required to ensure that the file from the zigbee repo is incorporated into the system?
… On 28 Sep 2019, at 11:27, Christoph Weitkamp ***@***.***> wrote:
I can remember we talked about this some time ago (see openhab/org.openhab.binding.zigbee#454 (comment) <openhab/org.openhab.binding.zigbee#454 (comment)>) but to be honest I do not know if someone started working on it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#972?email_source=notifications&email_token=AAH6IQ32M34JPBG2ZWNB6JTQL4WQBA5CNFSM4I2SPFLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD72VYKI#issuecomment-536173609>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAH6IQ42H5U347HZYUMNVKTQL4WQBANCNFSM4I2SPFLA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of the zigbee libraries in use is out-of-date.