-
-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document addon installation in Karaf from Marketplace #2272
Conversation
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
8084ec5
to
9651b28
Compare
Not necessarily. Before OH 4, there was no Nashorn add-on. The only place to install it was from the Marketplace. After OH 4 was released, the Nashorn add-on became an official add-on. But official add-ons and Marketplace add-ons are different add-ons. So if you had a Marketplace add-on installed and then later installed the official add-on, it doesn't replace the Marketplace add-on. Based on the output you show above, I would conclude you have both the Marketplace and the official Nashorn add-on installed. You should remove the Marketplace add-on. You should see two entries for JS (Nashorn) under Add-on store -> Automation (note that in OH 4.2 M1 the organization of the add-on store has changed and you'll see them in the Automation section on the same page, not more separate tab). Click on each of them and it should be apparent which one comes from the Marketplace and you can remove it from there. Or you can remove the marketplace one through the console. You should not have both installed and I don't think the Marketplace version is being maintained any longer. Those add-ons with an ID "binding-name" are official add-ons. Those add-ons with an ID "marketplace:xxxxxxx" come from the marketplace. |
I tried to reproduce the above output, but now the only service I get is:
while the web interface :8080/addons/bindings does show things like Adorne binding, air-Q Binding, AllPlay Binding. I do not have Nashorn installed, it is returned twice by
Is this described somewhere? Does the web interface (:8080/addons/) offer only official-addons, or also Marketplace add-ons? |
I don't know but they are posted in a different place, they are listed separately in the Add-ons store, have a different ID, and they are provided by a separate add-on service. Given all of that it seems obvious to me they are different. You can find the "karaf" Nashorn add-on at https://github.com/openhab/openhab-addons/tree/main/bundles/org.openhab.automation.jsscriptingnashorn and the marketplace one at https://community.openhab.org/t/javascript-scripting-nashorn-3-3-0-0-4-0-0-0/134770. Note that that posting on the forum is the source for this add-on. The forum is the marketplace. OH pulls these add-ons from that category in the forum.
By default it only provides the list of official add-ons (i.e. karaf add-ons). However, if you set the service ID to "marketplace" it will give you the marketplace add-ons. Use /addons/services to see the list of all the addons services enabled on your system (I have jar, karaf (official add-ons), marketplace (official OH marketplace), and json (smarthomej marketplace). For example: http://openhab:8080/rest/addons?serviceId=marketplace. I'm sure there's an openhab:addons equivalent to that on the console as well. I can't get into my karaf console at the moment (I've not tried since updating to OH 4.2 M1, may be a regression?) but I can messed around with the addons REST API endpoints. I'm assuming the endpoints match. My mistake above. I misunderstood what Back to the original question, looking at https://next.openhab.org/docs/administration/runtime.html it appears that the new |
@rkoshak Would you then agree to the PR that @dilyanpalauzov has provided? |
as implemented in openhab/openhab-core#4057 .
9651b28
to
2a54c94
Compare
This change is about briefly mentioning the opportunity in Karaf to use |
I don't have any problem with what's in this PR. But if documenting what the difference is between the four add-on services is out of scope for here I can't think of anywhere else it would go. |
as implemented in openhab/openhab-core#4057 .
I do not understand how exactly the
openhab:addon list
command is supposed to work.With OH 4.2.0M1 I can do in karaf
openhab:addons list karaf
oropenhab:addons list marketplace
.The first lists as:
the second:
What is the difference between these, as in
? Aren’t all of them originating from the market place and why are then the names (ids) completely different?