New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update windows.md #262
Update windows.md #262
Conversation
[!] Changed file paths in all examples from `C:\openhab\ to `C:\openHAB2\ [!] Changed from RC1 to Stable Release info and download links [+] Added Windows service installation instructions [+] Other cosmetic changes Signed Off by: DimitrisSar
Unrelated to this PR (I'll look at it later), would you at all be intrigued to build a batch/script files for the service setup task? ;) |
Sure. The problem is now that I am trying to debug the service wrapper... |
@ThomDietrich : I am facing a challenge and I don't know how to address it... The Service Wrapper configuration file (stored in C:\openHAB2\userdata\etc\openHAB2-wrapper.conf in my example) requires massive changes for the service to work. When generated with the command It requires the following changes: I don't think that it would be good for the installation manual for Windows to include a step to fix the service wrapper configuration file since the number of changes is big... How to deal with this? Here is a working version with all these additions implemented (based on https://community.openhab.org/t/install-openhab-2-in-windows-10-as-windows-service/18375/8)
|
"If possible, the product should make documentation irrelevant" |
Very good point (to include a proper wrapper.conf in the OH2 distro)! I am not that good with scripting, but I will give it a try... maybe someone else can help also. I have also another concern: I am not certain that the changes that I made in the wrapper.config are enough to have a stable system (maybe some environment variable is missing or some other parameter is wrongly configured). We will need some testers to double check the file contents. |
Regarding this issue: Maybe you could come up with a documentation that does not include the service for now? We can re-add it as soon as the wrapper question is solved. Having an up to date article with corrected info is more critical than adding new possibilities at the moment. Regarding the wrapper: Just create a PR for distro and mention the problems you are seeing. Link the PR in the related community thread and the right people will comment. |
Yet another candidate openhab/openhab-distro#403 |
[-] Removed the windows service installation steps. The Karaf service wrapper configuration file is broken (see : https://community.openhab.org/t/documenting-openhab-2/10568/151) [!] I didn't update the section "Updating the openHAB Runtime". This needs some improvements because the instructions do not work (see: https://community.openhab.org/t/solved-openhab-2-update-issue/20978/7)
I pushed another update to windows.md, removing the windows service installation steps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, just a few comments.
Also did you see #244 ? Seems like we should not delete config.properties? Would you be able to check?
You didn't sign your commits. Please add your Sign-off-by including a mail address to the pull request description above. Thanks ;)
|
||
The following instructions will guide you through the process of setting up openHAB 2. | ||
|
||
## Prerequisites | ||
|
||
First, be sure to check that your system has the necessary [prerequisites]({{base}}/installation/index.html#prerequisites). | ||
|
||
Add the JAVA_HOME System Environment Variable in Windows: Navigate to | ||
`Control Panel\System and Security\System\Advanced system settings\Environment variables\System variables` and create a New System Variable based on your Java installation directory: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To stay in sync with other parts I'd suggest to put JAVA_HOME in ``.
The path through the Windows menu would be better described by -> or → or ➡
@@ -44,7 +53,7 @@ Assuming a successful install, you will now have various folders inside `C:\open | |||
## Backup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one C:\openhab
mentioning above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, Could you name the headline "File Locations" and bring everything in sync with http://docs.openhab.org/installation/linux.html#file-locations
That would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working on it now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed another small update
Check please @ThomDietrich
[+] Added `` to JAVA_HOME [+] Added `:arrow_right: to the windows navigation instructions for the System Environment Variable [!] Fixed the example directory in "Assuming a successful install, you will now have various folders inside `C:\openHAB2`:" [!] Changed from "Folder Structure" to "File Locations", replicating the linux.md way [!] Remove the update step to delete the `userdata\etc\config.properties` file... I will test the steps later and see if they work (haven't run them through yet to check them) Signed-Off-By: dimitris.sarantis@wired-net.gr
Great! Sadly we still have to correct a little detail. You've added |
Signed-off-by: Thomas Dietrich <thomas.dietrich@tu-ilmenau.de> (github: ThomDietrich)
I've done that quick fix. The article is merged now. Thanks for your great help Dimitris ;) |
Just an updated startupscript with some less hardcoded paths. Should only need modification on top to adapt to other install locations.
|
[!] Changed file paths in all examples from
C:\openhab\ to
C:\openHAB2[!] Changed from RC1 to Stable Release info and download links
[+] Added Windows service installation instructions
[+] Other cosmetic changes
Signed Off by: DimitrisSar (dimitris.sarantis@wired-net.gr)