New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial addition of jsondb overview #282
Conversation
Initial addition of jsondb overview
This is much better :) |
Sorry - much better than what??? The placeholder? |
Than this: #281 I didn't see your PR before, so I made an effort to type up something for the JsonDB |
Ah - sorry - I didn’t see that :). Maybe a combination is about right - mine was a quick writeup during lunchtime…
|
Hey @cdjackson, One change request: Could you please break down your paragraphs to one line per sentence? Thanks! |
users might need to know about more at times.
Ok - what more do you want me to add though?
Regarding the conflict with @AngelosF <https://github.com/AngelosF>, I would suggest to merge yours first and he can merge his content in the next step. (as suggested in #202 <#202>) Would you agree?
Yes - that’s fine. I would just suggest to be a bit careful about trying to explain the actual format of these files since there will be many of them, and they will evolve as the framework evolves. This is why I elected not to try and describe the content - up to you though.
|
Nothing, this was directed at your text, as in "more than nothing right now" :) |
@cdjackson I just wanted to merge this, sadly you still need to sign your contribution (squash commit message or simply in the initial posting) Thanks |
Sorry - did this during lunch at work so didn't use my standard tools ;) |
No problem. Thank you! @AngelosF ping 😉 |
Signed-off-by: Chris Jackson chris@cd-jackson.com