Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial addition of jsondb overview #282

Merged
merged 2 commits into from Feb 4, 2017

Conversation

cdjackson
Copy link
Contributor

@cdjackson cdjackson commented Jan 31, 2017

Signed-off-by: Chris Jackson chris@cd-jackson.com

@AngelosF
Copy link
Member

This is much better :)

@cdjackson
Copy link
Contributor Author

Sorry - much better than what??? The placeholder?

@AngelosF
Copy link
Member

AngelosF commented Jan 31, 2017

Than this: #281

I didn't see your PR before, so I made an effort to type up something for the JsonDB

@cdjackson
Copy link
Contributor Author

cdjackson commented Jan 31, 2017 via email

@ThomDietrich
Copy link
Member

Hey @cdjackson,
thank you! It will be great to have some documentation on the jsondb, users might need to know about more at times. Regarding the conflict with @AngelosF, I would suggest to merge yours first and he can merge his content in the next step. (as suggested in #202) Would you agree?

One change request: Could you please break down your paragraphs to one line per sentence? Thanks!

@cdjackson
Copy link
Contributor Author

cdjackson commented Feb 1, 2017 via email

@ThomDietrich
Copy link
Member

users might need to know about more at times.

Ok - what more do you want me to add though?

Nothing, this was directed at your text, as in "more than nothing right now" :)

@ThomDietrich
Copy link
Member

@cdjackson I just wanted to merge this, sadly you still need to sign your contribution (squash commit message or simply in the initial posting) Thanks

@cdjackson
Copy link
Contributor Author

Sorry - did this during lunch at work so didn't use my standard tools ;)

@ThomDietrich ThomDietrich merged commit 5be5bc2 into openhab:gh-pages Feb 4, 2017
@ThomDietrich
Copy link
Member

ThomDietrich commented Feb 4, 2017

No problem. Thank you!

@AngelosF ping 😉

@Confectrician Confectrician added this to the 2.x.x milestone Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants