Update guidelines.md #933
Merged
Update guidelines.md #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove eclipse smarthome references. * More concise * Add examples for logging * Merge null annotations part into this file * Use MUST instead of SHOULD in many places, where we nowadays enforce such rules * OSGi framework level R5 Signed-off-by: David Graeff <david.graeff@web.de>
|
Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits). Built with commit 304ef79 https://deploy-preview-933--openhab-docs-preview.netlify.com |
5iver
reviewed
Apr 9, 2019
review comments Signed-off-by: David Graeff <david.graeff@web.de>
davidgraeff
pushed a commit
to davidgraeff/openhab-docs
that referenced
this pull request
Apr 10, 2019
For openhab#933 Signed-off-by: David Gräff <david.graeff@web.de>
This was referenced Apr 10, 2019
Merged
Confectrician
pushed a commit
that referenced
this pull request
Apr 11, 2019
For #933 Signed-off-by: David Gräff <david.graeff@web.de>
Confectrician
requested changes
Apr 11, 2019
Co-Authored-By: davidgraeff <david.graeff@web.de>
review comments Signed-off-by: David Graeff <david.graeff@web.de>
|
Comments addressed |
Confectrician
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was one big blob of text. I have added some life to it with examples and an extension directory layout etc.
The most controversial point is OSGi R5, but I think it is about to be time. We are running openHAB on R6 already and DS 1.3 is just to helpful to ignore it.
Signed-off-by: David Graeff david.graeff@web.de