Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added action.devices.commands.ThermostatSetMode #38

Closed
wants to merge 10 commits into from
Closed

Added action.devices.commands.ThermostatSetMode #38

wants to merge 10 commits into from

Conversation

alibahba
Copy link
Contributor

Should fix 37.
Added action.devices.commands.ThermostatSetMode to change the thermostat mode via GA

alibahba and others added 2 commits May 27, 2018 22:02
some bugfixes for executing multiple commands. "Set heating to 20 degrees" makes 2 commands in 1 request. The second command takes the wrong part of date since it always takes the first value of the array.
@alibahba
Copy link
Contributor Author

alibahba commented Aug 31, 2018

Some fixes for executing multiple commands in 1 request.
No longer the response from google assistant "Sorry, I couldn't reach OpenHab" when you ask the assistant: "Set heating to 20 degrees".

@alibahba
Copy link
Contributor Author

alibahba commented Sep 2, 2018

Added support for scenes due to the scene tag. Scenes will be visible in google assistant as scene and no longer as a switch.

alibahba and others added 4 commits September 4, 2018 08:25
Changed WillReportState to false since this function is not implemented.
Added Scene to the readme file.
Adde the Outlet.
When using the [ "Outlet" ] tag in a switch item, the item is synct to Google Assistant as a true outlet.
@alibahba
Copy link
Contributor Author

Added the outlet!
Use the [ "Outlet" ] tag and your item will appear as a true outlet in the Google Home app.

@marziman
Copy link
Collaborator

Hi @alibahba ,

First of all: Thanks and great you contribute!
I wanted to merge these things in.
There are some things which are not so ideal:

  • You should def. use a verified signature and sign your commits
  • It is not so good, that you made a PR for ThermostatSetMode but introduced new cool features :-)

So maybe we can divide this PR off? So I can test it much easier and we can lower the risk of
creating unwanted side effects? Would be great...

Let me know what you think?

@alibahba
Copy link
Contributor Author

Hi @marziman,

For now, I think I can't sign the current commits.
I will fix that for feature commits.

Sorry I have added new features in the same PR.
For now, in my opinion, that's not a big problem.

The features Scene and Outlet are really small.
All the rest is for the thermostat issue's.
In the above commits you can see what code is changed for whitch issue.
Off course ive test it all on my own google actions test environment.

@alibahba alibahba closed this Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants