init.d updates, fix restart and stop kill pid not in pidfile #30

[abedwardsw]

• restart should wait for process to stop, otherwise it doesn't work
• stop, if the pidfile is incorrect, then it should also check for the existing process and stop it
• rework into functions so we can re-use logic for stop/start in the restart call

[BClark09]

Hi @abedwardsw, many thanks for the PR! I've tested this on Ubuntu 14 and it works for me!

Please could you sign off your commit as per the contributing guide? You can also link this PR to the issue you created by saying in the description "closes #30" and "closes #28"

@theoweiss Do you have any code formatting comments?

[abedwardsw]

@BClark09 commit message updated, please have a look.

[BClark09]

Perfect, thanks! I'm happy with it but I'll wait a bit for @theoweiss to agree and then we'll merge!

[theoweiss]

LGTM.

@BClark09 The code formatting has to be fixed in general. We have not yet defined a formatting, but should do.

@abedwardsw Could you - for now - intend your code additions with 2 blanks and add a line like this to your next commit message: Signed-off-by: Adam Edwards <_your@email.org_> (github: abedwardsw)

Thanks!

[abedwardsw]

@BClark09 @theoweiss new commit created (rebased). Should be good now according to the "standard.."

[BClark09]

Many thanks @abedwardsw!