SPK openHAB 3.1.0 #188
SPK openHAB 3.1.0 #188
Conversation
tknaller
force-pushed
the
main
branch
3 times, most recently
from
6858c46
to
8ee850c
Compare
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tknaller)
-- commits, line 7 at r1:
Same message the two commits should be squashed
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tknaller)
There was a problem hiding this comment.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @Toover)
Previously, Toover wrote…
Same message the two commits should be squashed
Done.
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tknaller)
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:
README.md
Outdated
|
|
||
| You need Java 11 to be able to run openHAB >= 3.0.0, so please download AdoptOpenJDK for [arm32](https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download/jdk-11.0.9.1%2B1/OpenJDK11U-jdk_aarch64_linux_hotspot_11.0.9.1_1.tar.gz) because Oracle is not offering 32bit compatible package. | ||
| You need Java 11 to be able to run openHAB >= 3.1.0, so please download AdoptOpenJDK for [arm32](https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download/jdk-11.0.9.1%2B1/OpenJDK11U-jdk_aarch64_linux_hotspot_11.0.9.1_1.tar.gz) because Oracle is not offering 32bit compatible package. |
There was a problem hiding this comment.
For 214play and other 32bit based intel systems you can download a working java11 version from https://bell-sw.com/pages/downloads/#/java-11-lts
Signed-off-by: tknaller <thomas@knaller.info>
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @eporsche, @tknaller, and @Toover)
README.md, line 20 at r2 (raw file):
Previously, eporsche wrote…
For 214play and other 32bit based intel systems you can download a working java11 version from https://bell-sw.com/pages/downloads/#/java-11-lts
updated text. getting the feeling that contributing a little fix made me maintainer...
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eporsche)
^^ ..hope to see this getting merged. I created an spk from your change and it works great on my DS214play with DSM 6! |
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eporsche)
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eporsche)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eporsche)
SPK openHAB 3.1.0, replace bintray with jfrog
This change is