Added functionality to open openHAB Preview on macOS based systems

[dennisausbremen]

Unfortunately I'm not able to test on Linux atm.
Since there seems to be no "configurability" in VSCode extensions a lot has to be hardcoded. 😞

Closes #15

[kubawolanin]

Hi @dennisausbremen! Thank you for your contribution.

Since there seems to be no "configurability" in VSCode extensions a lot has to be hardcoded

In fact, there is a way to provide configuration points for the extension. Please take a look:

https://code.visualstudio.com/docs/extensionAPI/extension-points#_contributesconfiguration

All we need to do is to add a "configuration" node within "contributes" in package.json:
https://github.com/openhab/openhab-vscode/blob/master/package.json#L27

    "configuration": {
        "type": "object",
        "title": "openHAB configuration",
        "properties": {
            "openhab.hostname": {
                "type": "string",
                "default": null, // or 'localhost' ?
                "description": "Hostname or IP address of openHAB instance."
            }
        }
    }

And then in the code you would just use this config like this:

let config = vscode.workspace.getConfiguration('openhab')
console.log(config.hostname) // localhost or openhabianpi etc.

A few remarks, though:

• We'll need to parse the value in case user provides it with protocol and/or port, e.g. http://home or home:8080. - What we need is home only :-) We will reuse that in further features, like REST connection mentioned in Code completion for Items, Things etc. #7
• README.md file would need to change as well as we're introducing a configuration point here.

Thanks again!

[kubawolanin]

Just a thought. We could utilize Node.js path library so it does the detection for us :)

[dennisausbremen]

Yes, it was late yesterday. 😄
Will do.
Thanks for the input! 🎉

[dennisausbremen]

In fact, there is a way to provide configuration points for the extension. Please take a look

I think i just missed that. Great. 😆 👍

The main problem with the parsing of the correct path is, that it just works somewhat great on windows. 😞
Maybe we should abandon the auto-detection alltogether or make it optional or detect if the user is using "win32" to automatically turn it on, since it's of no real use on a mac or *NIX machine.

We'll need to parse the value in case user provides it with protocol and/or port
Using path() that should be no problem. 😉

README.md file would need to change as well as we're introducing a configuration point here.
I agree. 👍

[kubawolanin]

Maybe we should abandon the auto-detection alltogether

I'm perfectly fine with this. Let's just make sure that hostname provided in the user settings could be reusable.

Cheers! 😃

[dennisausbremen]

Updated my code to accomodate your feedback.

[kubawolanin]

Awesome @dennisausbremen , thank you so much for your enhancements! 🥇

[kubawolanin]

+1 for openHABian recognition! :-)

[ThomDietrich]

+1 Indeed 😄

[kubawolanin]

@dennisausbremen your changes LGTM overall. There's one thing that's needed from you before I merge it.

Can you squash your commits and change commit message to include a Signed-off-by (to certify that you wrote it or otherwise have the right to pass it on as an open-source), see http://docs.openhab.org/developers/contributing/contributing.html#sign-your-work

For squashing / rebasing see:
http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

Also, if you edit your first comment with Closes #15 annotation, it'll automatically refer to and close the issue you've created. Thanks!

[dennisausbremen]

@kubawolanin: Like this? 😄
Whatever that grey github thingie means.

[kubawolanin]

perfecto! Thanks again mate!

[dennisausbremen]

No problem! 🍸😎👍