Skip to content

Commit

Permalink
Rule/script: Fix fields not editable in create mode or for Blockly (#…
Browse files Browse the repository at this point in the history
…2318)

Regression from #2276 which caused a new rule unable to be created
because the rule name/description couldn't be entered (fields are
disabled)

---------

Also-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
  • Loading branch information
jimtng committed Feb 7, 2024
1 parent 1d5d217 commit 362d9f3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export default {
return this.rule.tags.filter((t) => !this.isScriptTag(t) && !this.isSceneTag(t)).length
},
editable () {
return this.rule && this.rule.editable
return this.createMode || (this.rule && this.rule.editable)
}
},
methods: {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<template>
<div>
<rule-general-settings v-if="createMode || isScriptRule" :ready="true" :rule="rule" :createMode="createMode" :isEditable="true" :inScriptEditor="true" />
<rule-general-settings v-if="createMode || isScriptRule" :ready="true" :rule="rule" :createMode="createMode" :inScriptEditor="true" />
<f7-block class="block-narrow">
<f7-col v-if="!createMode && languages">
<f7-block-title>Scripting Language</f7-block-title>
<f7-list media-list>
<f7-list-item media-item radio radio-icon="start" :disabled="true"
<f7-list-item media-item radio radio-icon="start" :disabled="!editable"
:value="mode" :checked="mode === language.contentType" @change="$emit('newLanguage', language.contentType)"
v-for="language in languages" :key="language.contentType"
:title="language.name" :after="language.version" :footer="language.contentType" />
Expand All @@ -26,7 +26,7 @@ export default {
},
computed: {
editable () {
return this.rule && this.rule.editable
return this.createMode || (this.rule && this.rule.editable)
}
}
}
Expand Down

0 comments on commit 362d9f3

Please sign in to comment.