Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BasicUI] Slider not working well, especially in Firefox #2525

Closed
1 of 4 tasks
lolodomo opened this issue Apr 6, 2024 · 0 comments · Fixed by #2535
Closed
1 of 4 tasks

[BasicUI] Slider not working well, especially in Firefox #2525

lolodomo opened this issue Apr 6, 2024 · 0 comments · Fixed by #2535
Labels
basic ui Basic UI bug Something isn't working

Comments

@lolodomo
Copy link
Contributor

lolodomo commented Apr 6, 2024 •
edited

Which UI are you reporting an issue for?

  • Basic UI
  • HABPanel
  • HABot
  • CometVisu

The problem

When clicking in the slider using a mouse, two problems can occur:

  1. Basic UI emits an event to the bus but with the old value of the slider => the item state is not changed
  2. Basic UI emits a correct event to the bus but the feedback SSE event is ignored and the value at the left of the slider is not updated

The first issue occurs almost all the time when using Firefox but not when using Chrome.
The difference between Firefox and Chrome is that Firefox receives first event mouseup and then event change, while Chrome receives events in the reverse order. Maybe the new value is not yet available until event change is received.

The second problem can occur in Firefox and in Chrome. It could be because resuming of listening to SSE events is resumed too late.

Expected behavior

  1. Correct event with the new value should be sent to the bus when using Firefox.
  2. The value displayed at left of the slider should always be correctly refreshed.

Your environment

Windows 10, with Firefox or Chrome browser.
@lolodomo lolodomo added bug Something isn't working basic ui Basic UI labels Apr 6, 2024
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Apr 19, 2024
@lolodomo
[BasicUI] Fix slider behaviour and implement two different modes
358e2f5 
Fix openhab#2525

Two behaviour modes are now supported.
- If releaseOnly attribute is set, the new value is sent to the item only when the slider is released.
- If releaseOnly attribute is unset, new values are sent to the item while moving the slider. Events are sent at a certain frequency, this frequency is defined by the sendFrequency attribute if set or every 200 ms by default.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Apr 19, 2024
@lolodomo
[BasicUI] Fix slider behaviour and implement two different modes
d9cc5af 
Fix openhab#2525
Related to openhab/openhab-core#4084

Two behaviour modes are now supported.
- If releaseOnly attribute is set, the new value is sent to the item only when the slider is released.
- If releaseOnly attribute is unset, new values are sent to the item while moving the slider. Events are sent at a certain frequency, this frequency is defined by the sendFrequency attribute if set or every 200 ms by default.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo mentioned this issue Apr 19, 2024
Merged
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Apr 19, 2024
@lolodomo
[BasicUI] Fix slider behaviour and implement two different modes
4a0ca86 
Fix openhab#2525
Related to openhab/openhab-core#4084

Two behaviour modes are now supported.
- If releaseOnly attribute is set, the new value is sent to the item only when the slider is released.
- If releaseOnly attribute is unset, new values are sent to the item while moving the slider. Events are sent at a certain frequency, this frequency is defined by the sendFrequency attribute if set or every 200 ms by default.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Apr 19, 2024
@lolodomo
[BasicUI] Fix slider behaviour and implement two different modes
0463bae 
Fix openhab#2525
Related to openhab/openhab-core#4084

Two behaviour modes are now supported.
- If releaseOnly attribute is set, the new value is sent to the item only when the slider is released.
- If releaseOnly attribute is unset, new values are sent to the item while moving the slider. Events are sent at a certain frequency, this frequency is defined by the sendFrequency attribute if set or every 200 ms by default.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Apr 19, 2024
@lolodomo
[BasicUI] Fix slider behaviour and implement two different modes
6d154f1 
Fix openhab#2525
Related to openhab/openhab-core#4084

Two behaviour modes are now supported.
- If releaseOnly attribute is set, the new value is sent to the item only when the slider is released.
- If releaseOnly attribute is unset, new values are sent to the item while moving the slider. Events are sent at a certain frequency, this frequency is defined by the sendFrequency attribute if set or every 200 ms by default.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Apr 19, 2024
@lolodomo
[BasicUI] Fix slider behaviour and implement two different modes
f746ad4 
Fix openhab#2525
Related to openhab/openhab-core#4084

Two behaviour modes are now supported.
- If releaseOnly attribute is set, the new value is sent to the item only when the slider is released.
- If releaseOnly attribute is unset, new values are sent to the item while moving the slider. Events are sent at a certain frequency, this frequency is defined by the sendFrequency attribute if set or every 200 ms by default.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Apr 19, 2024
@lolodomo
[BasicUI] Fix slider behaviour and implement two different modes
ecc93a9 
Fix openhab#2525
Related to openhab/openhab-core#4084

Two behaviour modes are now supported.
- If releaseOnly attribute is set, the new value is sent to the item only when the slider is released.
- If releaseOnly attribute is unset, new values are sent to the item while moving the slider. Events are sent at a certain frequency, this frequency is defined by the sendFrequency attribute if set or every 200 ms by default.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Apr 19, 2024
@lolodomo
[BasicUI] Fix slider behaviour and implement two different modes
106e36a 
Fix openhab#2525
Related to openhab/openhab-core#4084

Two behaviour modes are now supported.
- If releaseOnly attribute is set, the new value is sent to the item only when the slider is released.
- If releaseOnly attribute is unset, new values are sent to the item while moving the slider. Events are sent at a certain frequency, this frequency is defined by the sendFrequency attribute if set or every 200 ms by default.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Apr 19, 2024
@lolodomo
[BasicUI] Fix slider behaviour and implement two different modes
9f46ac9 
Fix openhab#2525
Related to openhab/openhab-core#4084

Two behaviour modes are now supported.
- If releaseOnly attribute is set, the new value is sent to the item only when the slider is released.
- If releaseOnly attribute is unset, new values are sent to the item while moving the slider. Events are sent at a certain frequency, this frequency is defined by the sendFrequency attribute if set or every 200 ms by default.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Apr 19, 2024
@lolodomo
[BasicUI] Fix slider behaviour and implement two different modes
ccfd1ef 
Fix openhab#2525
Also related to openhab/openhab-core#4084 and openhab/openhab-core#3430

Two behaviour modes are now supported.
- If releaseOnly attribute is set, the new value is sent to the item only when the slider is released.
- If releaseOnly attribute is unset, new values are sent to the item while moving the slider. Events are sent at a certain frequency, this frequency is defined by the sendFrequency attribute if set or every 200 ms by default.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Apr 19, 2024
@lolodomo
[BasicUI] Fix slider behaviour and implement two different modes
651099e 
Fix openhab#2525
Also related to openhab/openhab-core#4084 and openhab/openhab-core#3430

Two behaviour modes are now supported.
- If releaseOnly attribute is set, the new value is sent to the item only when the slider is released.
- If releaseOnly attribute is unset, new values are sent to the item while moving the slider. Events are sent at a certain frequency, this frequency is defined by the sendFrequency attribute if set or every 200 ms by default.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Apr 19, 2024
@lolodomo
[BasicUI] Fix slider behaviour and implement two different modes
215b026 
Fix openhab#2525
Also related to openhab/openhab-core#4084 and openhab/openhab-core#3430

Two behaviour modes are now supported.
- If releaseOnly attribute is set, the new value is sent to the item only when the slider is released.
- If releaseOnly attribute is unset, new values are sent to the item while moving the slider. Events are sent at a certain frequency, this frequency is defined by the sendFrequency attribute if set or every 200 ms by default.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Apr 20, 2024
@lolodomo
[BasicUI] Fix slider behaviour and implement two different modes
3696dbf 
Fix openhab#2525
Also related to openhab/openhab-core#4084 and openhab/openhab-core#3430

Two behaviour modes are now supported.
- If releaseOnly parameter is set, the new value is sent to the item only when the slider is released.
- If releaseOnly parameter is not set, new values are sent to the item while moving the slider. Events are sent at a certain frequency, this frequency is defined by the sendFrequency parameter if set or every 200 ms by default. Event is not sent when the value is is unchanged (when stopping the move but keeping the mouse pressed).

The brightness slider of the colorpicker widget is also updated to send regular new color commands when moving the slider.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
kaikreuzer pushed a commit that referenced this issue Apr 21, 2024
@lolodomo
[BasicUI] Fix slider behaviour and implement two different modes (#2535)
0c7aa4d 
Fix #2525
Also related to openhab/openhab-core#4084 and openhab/openhab-core#3430

Two behaviour modes are now supported.
- If releaseOnly parameter is set, the new value is sent to the item
only when the slider is released.
- If releaseOnly parameter is not set, new values are sent to the item
while moving the slider. Events are sent at a certain frequency, this
frequency is defined by the sendFrequency parameter if set or every 200
ms by default. Event is not sent when the value is is unchanged (when
stopping the move but keeping the mouse pressed).

The brightness slider of the colorpicker widget is also updated to send
regular new color commands when moving the slider.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
basic ui Basic UI bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BasicUI] Fix slider behaviour and implement two different modes lolodomo/openhab-webui
1 participant
@lolodomo