Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MainUI] Display of thing channels no more happening #422

Closed
lolodomo opened this issue Oct 19, 2020 · 1 comment · Fixed by openhab/openhab-core#1739
Closed

[MainUI] Display of thing channels no more happening #422

lolodomo opened this issue Oct 19, 2020 · 1 comment · Fixed by openhab/openhab-core#1739
Labels
bug Something isn't working main ui Main UI

Comments

@lolodomo
Copy link
Contributor

lolodomo commented Oct 19, 2020 •
edited
Loading

After 2 hours searching what could be the error in the code I changed today, I finally discovered that even with another binding (unchanged), the main UI is now no more able to display the thing channels. There is a kind of blinking.
image
My Eclipse resolves with this version:
image
Yesterday, it was working but I think the UI was from the 16th of this month.
@ghys
Copy link
Member

ghys commented Oct 19, 2020

I think it's due to a regression/bug introduced by openhab/openhab-core#1713.
If you check the browser's dev tools, the thing-types & channel-types API are likely 403 forbidden to administrators.
I fixed it in openhab/openhab-core#1735.

@ghys ghys added bug Something isn't working main ui Main UI labels Oct 19, 2020
ghys added a commit to ghys/openhab-core that referenced this issue Oct 19, 2020
@ghys
Add missing roles checks
aa5ec58 
(I included these fixes in openhab#1735 but extracted them in a stanalone
PR because it's easier to review and a little more urgent.)

As a result of the refactoring in openhab#1713, the operations annotated with
`@RolesAllowed` containing `Role.USER` are not anymore automatically
considered accessible to all users, regardless of their actual roles.

4 operations are therefore now denied to admins if they only have the
`Role.ADMIN` role, as the first admininistrator is created only with
that role the UI encounters unexpected access denied errors and breaks.
(See openhab/openhab-webui#422).

Closes openhab/openhab-webui#422.

Signed-off-by: Yannick Schaus <github@schaus.net>
@ghys ghys mentioned this issue Oct 19, 2020
Merged
kaikreuzer pushed a commit to openhab/openhab-core that referenced this issue Oct 20, 2020
@ghys
Add missing roles checks (#1739)
d262b6f 
(I included these fixes in #1735 but extracted them in a stanalone
PR because it's easier to review and a little more urgent.)

As a result of the refactoring in #1713, the operations annotated with
`@RolesAllowed` containing `Role.USER` are not anymore automatically
considered accessible to all users, regardless of their actual roles.

4 operations are therefore now denied to admins if they only have the
`Role.ADMIN` role, as the first admininistrator is created only with
that role the UI encounters unexpected access denied errors and breaks.
(See openhab/openhab-webui#422).

Closes openhab/openhab-webui#422.

Signed-off-by: Yannick Schaus <github@schaus.net>
@rgrollfitz rgrollfitz mentioned this issue Oct 20, 2020
Closed
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this issue Jul 11, 2023
@ghys @splatch
Add missing roles checks (openhab#1739)
a09d000 
(I included these fixes in openhab#1735 but extracted them in a stanalone
PR because it's easier to review and a little more urgent.)

As a result of the refactoring in openhab#1713, the operations annotated with
`@RolesAllowed` containing `Role.USER` are not anymore automatically
considered accessible to all users, regardless of their actual roles.

4 operations are therefore now denied to admins if they only have the
`Role.ADMIN` role, as the first admininistrator is created only with
that role the UI encounters unexpected access denied errors and breaks.
(See openhab/openhab-webui#422).

Closes openhab/openhab-webui#422.

Signed-off-by: Yannick Schaus <github@schaus.net>
GitOrigin-RevId: d262b6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing roles checks ghys/openhab-core
2 participants
@ghys @lolodomo