Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enlarge border around openHAB logo for aesthetics #1056

Merged
merged 1 commit into from May 24, 2021
Merged

Enlarge border around openHAB logo for aesthetics #1056

merged 1 commit into from May 24, 2021

Conversation

ecdye
Copy link
Contributor

@ecdye ecdye commented May 19, 2021

Signed-off-by: Ethan Dye mrtops03@gmail.com

@ecdye ecdye requested a review from a team as a code owner May 19, 2021 03:25
@relativeci
Copy link

relativeci bot commented May 19, 2021 •
edited

Job #126: Bundle Size — 10.4MB (-0.06%).

64c34a2 vs 8cbd265

Changed metrics (1/8)
Metric Current Baseline
Cache Invalidation 1.4% 16.71%
Changed assets by type (2/7)
            Current     Baseline
IMG 140.74KB (-4.12%) 146.79KB
JS 8.14MB (~-0.01%) 8.14MB

View Job #126 report on app.relative-ci.com

@ecdye ecdye marked this pull request as draft May 19, 2021 17:33
@ecdye
Enlarge border around openHAB logo for aesthetics
a3b7a17 
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
@ecdye ecdye marked this pull request as ready for review May 19, 2021 18:44
ghys
ghys approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, they look a little nicer indeed especially on non-"retina" displays.

Before/after comparisons for reference:

image
image

@ghys ghys merged commit 11a0301 into openhab:main May 24, 2021
@ghys ghys added this to the 3.1 milestone May 30, 2021
@ghys ghys added main ui Main UI enhancement New feature or request labels May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ecdye @ghys