Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix layout pages' grid item button & Allow link to be added when there is none #1070

Merged
merged 1 commit into from May 26, 2021
Merged

Fix layout pages' grid item button & Allow link to be added when there is none #1070

merged 1 commit into from May 26, 2021

Conversation

hubsif
Copy link
Contributor

@hubsif hubsif commented May 26, 2021

Increase z-index for grid-item handles - see community forums
Allow link to be added when there is none - on item-details
Remove leftover from #1055 - removal of onPageAfterIn

@hubsif
Increase z-index for grid-item handles
5e88802 
Allow link to be added when there is none
Remove leftover from openhab#1055

Signed-off-by: Hubert Nusser <hubsif@gmx.de>
@hubsif hubsif requested a review from a team as a code owner May 26, 2021 12:55
@relativeci
Copy link

relativeci bot commented May 26, 2021

Job #134: Bundle Size — 10.4MB (~-0.01%).

6ca7fdb vs 2abfe4c

Changed metrics (3/8)
Metric Current Baseline
Initial JS 1.6MB(~-0.01%) 1.6MB
Initial CSS 602.07KB(~+0.01%) 602.06KB
Cache Invalidation 26.9% 7.25%
Changed assets by type (2/7)
            Current     Baseline
CSS 837.21KB (~+0.01%) 837.2KB
JS 8.14MB (~-0.01%) 8.14MB

View Job #134 report on app.relative-ci.com

ghys
ghys approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove leftover from #1055 - removal of onPageAfterIn

thanks - I noticed and was about to mention it ;)
LGTM

@ghys ghys merged commit 2a10cc1 into openhab:main May 26, 2021
@ghys ghys changed the title Minor changes Fix layout pages' grid item button & Allow link to be added when there is none May 30, 2021
@ghys ghys added bug Something isn't working main ui Main UI labels May 30, 2021
@ghys ghys added this to the 3.1 milestone May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hubsif @ghys