New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update alexa integration with new metadata syntax #1145
Conversation
e1e7e7d
to
d3c71b9
Compare
Job #239: Bundle Size — 10.69MB (-0.09%).Changed metrics (3/8)
|
Signed-off-by: jsetton <jeremy.setton@gmail.com>
@ghys could you take a look at this one when you have a chance? It's pretty much ready for review. They will be some minor data input changes based on the beta testing feedback and bug fixes. I just want to make sure that we can merge this one once we move the Alexa metadata changes to the live skill. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the huge update @jsetton - I only have a few minor comments, apart from those the code looks good, on the functionality itself I'll trust you as I don't use Alexa or follow the latest developments.
bundles/org.openhab.ui/web/src/components/item/metadata/item-metadata-alexa.vue
Outdated
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/assets/definitions/metadata/alexa/helpers.js
Outdated
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/components/item/metadata/item-metadata-alexa.vue
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/components/item/metadata/item-metadata-alexa.vue
Outdated
Show resolved
Hide resolved
Signed-off-by: jsetton <jeremy.setton@gmail.com>
@ghys sorry for the delay. I made the changes based on your review comments. Let me know what you think. |
@jsetton thanks - I have no more comments. |
Signed-off-by: jsetton <jeremy.setton@gmail.com>
@ghys Not sure if you saw my last review request. I wanted to make sure you are fine with the last change I made with the items query. We are currently planning to move forward with the production release next week. |
I don't see the comment, maybe you started a review and forgot to finish it? (it should say "pending" so you have to click on the green button on the top-right to finish the review). |
bundles/org.openhab.ui/web/src/components/item/metadata/item-metadata-alexa.vue
Outdated
Show resolved
Hide resolved
I just switched to a single comment. Can you see it now? |
Signed-off-by: jsetton <jeremy.setton@gmail.com>
@ghys I decided to change how cross-device connections are defined with the network capabilities using group relationships in the end. This means that I reverted the items query to just pulling specific group items. So that should limit heavy requests. As far as your last comment, I have moved the API requests from Hopefully, you are fine with the last change. This is the last functional change that I will be making on this PR. |
These changes are fine by me! |
Signed-off-by: jsetton <jeremy.setton@gmail.com>
@ghys This PR is ready to be merged. Relevant changes have been merged and deployed to the production environment. |
Looking forward to seeing this merged! @jsetton has our next release of the Alexa skill ready to go. |
Job #254: Bundle Size — 10.78MB (+0.31%). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this extensive overhaul! - since I don't use Alexa I will trust you on the functional side, but the UI seems to work at it should, and the code lgtm.
Related to openhab/openhab-alexa#394.
This change should be merged after the new metadata syntax is released to the production environment.
Since the new syntax is backward compatible, users of previous GUI versions will still be able to use the old interface.