Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blockly] change help urls to official OH blockly rules docs #1337

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

stefan-hoehn
Copy link
Contributor

Signed-off-by: Stefan Höhn stefan@andreaundstefanhoehn.de

This PR changes all blocks' help URL to point to the official openhab blockly documentation.

Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
@stefan-hoehn stefan-hoehn requested a review from a team as a code owner March 7, 2022 23:15
@relativeci
Copy link

relativeci bot commented Mar 7, 2022

Job #377: Bundle Size — 10.7MB (-0.03%).

d53c94a vs 4ced115

Changed metrics (4/10)
Metric Current Baseline
Initial JS 1.67MB(-0.09%) 1.67MB
Initial CSS 605.15KB(-0.28%) 606.86KB
Cache Invalidation 29.81% 31.7%
Duplicate Code 1.97%(-0.51%) 1.98%
Changed assets by type (2/7)
            Current     Baseline
CSS 855.02KB (-0.2%) 856.73KB
JS 8.64MB (-0.02%) 8.64MB

View Job #377 report on app.relative-ci.com

@ghys
Copy link
Member

ghys commented Mar 8, 2022

There are new files ohblocks_exec.js & ohblocks_http.js in this PR which I suppose weren't intentionally included based on the description?

Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
@stefan-hoehn
Copy link
Contributor Author

There are new files ohblocks_exec.js & ohblocks_http.js in this PR which I suppose weren't intentionally included based on the description?

true, I still have them in my local repo as I intend them to contribute them eventually but not now (and not with that PR), so I agree not to add them to main at the moment. I have removed the files.

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

Although, there's the issue of which version of the docs to address - https://www.openhab.org or https://next.openhab.org - i.e. the stable or current docs, which have different updating workflows, and let's not even consider archived versions. In other parts of the code (the add-on store) there's this simplistic & flawed heuristic:

let url = `https://${this.$store.state.runtimeInfo.buildString === 'Release Build' ? 'www' : 'next'}.openhab.org` +

(though you probably don't have access to the Vuex store with that info from this code)

For now I think we can postpone the problem so I'll merge this.

@ghys ghys merged commit fbb9a7f into openhab:main Apr 5, 2022
@ghys ghys added the main ui Main UI label May 1, 2022
@ghys ghys added this to the 3.3 milestone May 1, 2022
@ghys ghys added the enhancement New feature or request label May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants