Configuration of context labels in Equipment and Properties card of homepage tabs. #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…operties card of homepage tabs. Options available are the path in model (joining parents label), the parent label, the item name or nothing. The possibility to trim beginning or end of path is also configurable. If nothing is selected, will display the footer defined in metadata (if any). Signed-off-by: Gautier Taravella <tarag@mailbox.org>
Job #402: Bundle Size — 10.71MB (+0.04%).Changed metrics (3/10)
|
ghys
approved these changes
May 29, 2022
There was a problem hiding this comment.
Thanks, LGTM.
I don't remember if I already told you this, but I think it could be great to have these settings on a per-card basis too, because deviating from the tab's default might make sense in some cases (like no context in some cards if the label is enough).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of configuration options available are the path in model (joining parents label), the parent label, the item name or nothing. The possibility to trim beginning or end of path is also configurable.
If nothing is selected, will display the footer defined in metadata (if any).
This should hopefully satisfy users who complained about the lack of configurability when the improvements of PR #1264 were introduced.