Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide link styling to list item used as equipment accordion item. #1408

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

tarag
Copy link
Contributor

@tarag tarag commented Jun 15, 2022

Provide link styling for equipment accordion item (pointer and hover colour), probably only for desktop.

Signed-off-by: Gautier Taravella <tarag@mailbox.org>
@tarag tarag requested a review from a team as a code owner June 15, 2022 06:18
@relativeci
Copy link

relativeci bot commented Jun 15, 2022

Job #418: Bundle Size — 10.74MB (~+0.01%).

aeb5ade vs 10fee05

Changed metrics (1/10)
Metric Current Baseline
Initial JS 1.67MB(~+0.01%) 1.67MB
Changed assets by type (1/7)
            Current     Baseline
JS 8.69MB (~+0.01%) 8.69MB

View Job #418 report on app.relative-ci.com

@ghys
Copy link
Member

ghys commented Jun 16, 2022

Thanks for the quick fix!
Not sure what's wrong with the CI builds though... @wborn could you advise?

@wborn
Copy link
Member

wborn commented Jun 16, 2022

If you retrigger the GHA CI builds they should now succeed because of the openhab/openhab-core#3001 workaround. I already retriggered the Jenkins build.

@ghys ghys merged commit 62855ef into openhab:main Jun 16, 2022
@ghys ghys added bug Something isn't working main ui Main UI labels Jun 16, 2022
@ghys ghys added this to the 3.3 milestone Jun 16, 2022
yfre pushed a commit to yfre/openhab-webui that referenced this pull request Jun 18, 2022
…penhab#1408)

Signed-off-by: Gautier Taravella <tarag@mailbox.org>
Signed-off-by: Eugen Freiter <freiter@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants