[blockly] Add new list, item, persistence, text blocks #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
…nting Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
Job #628: Bundle Size — 15.96MiB (+0.11%).Metrics (6 changes)
Total size by type (2 changes)
|
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
|
@ghys Do you mind having a quick look at it, so we can deliver it with the current milestone |
|
@lolodomo would you be able to review it, so there is a chance that it still can make it into main before the feature freeze? |
|
I'm still around... I'll review it and other pending PRs this week-end. |
Yannick, I know, I appreciate it. please take care of yourself.! 🤗 |
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
|
FYI I took the chance and added a few changes lately and a fix all of which are documented above. The reason is that by using the blocks myself I discovered some short comings, so I improved them. The PR is now stable again and ready to be reviewed. |
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
ghys
requested changes
Dec 4, 2022
bundles/org.openhab.ui/web/src/assets/definitions/blockly/utils.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
stefan-hoehn
force-pushed
the
blockly_new_blocks2
branch
from
4e165d3
to
2f3d3f3
Compare
|
@ghys Your change has been applied. |
Signed-off-by: Yannick Schaus <github@schaus.net>
ghys
approved these changes
Dec 10, 2022
kaikreuzer
changed the title
This was referenced Dec 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Höhn stefan@andreaundstefanhoehn.de
oh_text_replace: a new text replace block that is missing in the standard text block section
oh_taggeditems: retrieve a list of items identified by one or multiple tags
oh_list_concatenate: allows to concatenate two lists into a new lists
oh_get_persistvalue: add new previousState (new mutating block)
fixed type checking of oh_get_persistvalue: requires item name, not item
oh_zdt_fromText: Add time support
oh_transformation: fix help url
see some more info and example here: https://community.openhab.org/t/extending-blockly-with-new-openhab-commands/127169/394