Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix action options regression #1813

Merged
merged 1 commit into from Mar 29, 2023
Merged

Fix action options regression #1813

merged 1 commit into from Mar 29, 2023

Conversation

florian-h05
Copy link
Contributor

Fixes #1806, which is regression from #1734.

@florian-h05
Fix action options regression
c43e367 
Fixes openhab#1806, which is regression from openhab#1734.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 added this to the 4.0 milestone Mar 28, 2023
@florian-h05 florian-h05 requested a review from a team as a code owner March 28, 2023 16:17
@relativeci
Copy link

relativeci bot commented Mar 28, 2023

Job #880: Bundle Size — 15.66MiB (-0.01%).

2038fa7(current) vs cb6e61c main#879(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (2 changes)
                 Current
Job #880		      Baseline
Job #879
Initial JS 1.72MiB(-0.08%) 1.72MiB
Initial CSS 608.54KiB(-0.03%) 608.7KiB
Cache Invalidation 93.91% 93.91%
Chunks 219 219
Assets 689 689
Modules 1706 1706
Duplicate Modules 82 82
Duplicate Code 1.72% 1.72%
Packages 137 137
Duplicate Packages 15 15
Total size by type (3 changes)
                 Current
Job #880		      Baseline
Job #879
CSS 857.81KiB (-0.02%) 857.97KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.18MiB (-0.02%) 9.18MiB
Media 295.6KiB 295.6KiB
Other 4.7MiB (-0.02%) 4.7MiB

View job #880 report View main branch activity

@ghys ghys merged commit d5d6842 into openhab:main Mar 29, 2023
5 checks passed
@florian-h05 florian-h05 deleted the fix-1806 branch March 30, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
main ui Main UI regression
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Action Options Regression
2 participants
@florian-h05 @ghys