New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Items: Show non-semantic tags, relatesTo part of semantics & Use accordion tag input & Fix virtual box height #2087
Conversation
Semantic tags - display of relatesTo Non-semantic tags - move to accordion Signed-off-by: David Kesl <david_git@keslovi.cz>
Adds Non-semantic tags to Items list Adds relatesTo in Semantic tag line Fix of height in vue virtual list Signed-off-by: David Kesl <david_git@keslovi.cz>
Signed-off-by: David Kesl <david_git@keslovi.cz>
Signed-off-by: David Kesl <david_git@keslovi.cz>
Signed-off-by: David Kesl <david_git@keslovi.cz>
I now have full access to BrowserStack, so I have retested this PR once more for all combinations of most common browsers and devices. |
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
…to Item mixin Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, thanks!
I have changed a few things, notably:
- Rename the tag input in item-form.vue to Non-Semantic Tags to make clear that those are non-semantic. In this case IMO this is better, because Items support (in contrast to rules etc.) semantic tags.
- Move the
getItemTypeAndMetaLabel
method to a mixin and therefore de-duplicate code. It is actually used at three places, you only updated two because you did not notice the third. - Use the
isSemanticTag
logic as used bytag-input.vue
(move this to a mixin). - Move the
getNonSemanticTags
logic to a mixin, because it is used at several places in your PR. - Display tags in the
item.vue
component, so e.g. the list of group members looks the same as the Items list.
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Thanks for fixing the vList height on so many platforms & browsers, my changes should not change anything in this behaviour, therefore I only tested this by switching between the different themes. |
Thanks a lot for cleansing the code. Using the mixin.js is good idea and removes the code duplication. Will take it as lesson learned for my next PR's. |
…2095) Changes introduced into #2087 in combination with #2093 create duplicity in showing non-semantic tags in the model page (component/model/item-details.vue). Non-semantic tags are displayed both in the Item and when edit mode is enabled, in the accordion tag input in item-form. Signed-off-by: David Kesl <david_git@keslovi.cz>
Fixes openhab#2133. Regression from openhab#2087. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Closes #2086
getItemTypeAndMetaLabel
with relatesTo part of Semantic classification.item-form.vue
, so it is available also in Model view, when creating Item from Thing etc.At minimum for the calculation of vue virtual box height it would be great to fully test this PR for variety of browsers. Currently I do not have complete BrowserStack access avaible, but anyway I have tried to test and adjust height calculation for following browsers using trial and my own devices (This PR is tested with BrowserStack):
Windows – Chrome, Edge, Firefox
MacOS – Chrome
Linux – Chrome, Firefox
iOS – Safari, Chrome
Android - Chrome
I kindly ask maintainers to test this PR using BrowserStack for other browsers. If I get full access from BrowserStack in the meantime, I will complete the testing with other browsers as well.