Fix oh-stepper sends command on Item state update due to rounding
#2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-h05
changed the title
oh-stepper: oh-stepper: Fix command sent on external update due to rounding
Job #1380: Bundle Size — 15.83MiB (~+0.01%).Warning Bundle contains 16 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #1380 report View florian-h05:oh-stepper branch activity View project dashboard |
florian-h05
force-pushed
the
oh-stepper
branch
from
58e7177
to
0a651ac
Compare
florian-h05
changed the title
oh-stepper: Fix command sent on external update due to roundingoh-stepper send command on Item state update due to rounding
florian-h05
changed the title
oh-stepper send command on Item state update due to roundingoh-stepper sends command on Item state update due to rounding
|
@florian-h05 could you please rebase and revolve the conflcts? |
florian-h05
force-pushed
the
oh-stepper
branch
from
0a651ac
to
be28600
Compare
|
@ghys Done. |
florian-h05
force-pushed
the
oh-stepper
branch
from
be28600
to
287b18b
Compare
Fixes openhab#1186. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
force-pushed
the
oh-stepper
branch
from
287b18b
to
ba56b6a
Compare
|
@ghys Can you please have a look at this PR? I have now rebased it again. |
ghys
approved these changes
Jan 29, 2024
|
I have created that PR so long ago that I cannot even remember all the changes without looking at them 😂 But I do remember testing it on my dev system. Anyway, we are far away from the next release, so enough time to learn about possible regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1186: Widget sends command on external update due to rounding.
This is done by replacing the generic change listener with listeners for plusclick, minusclick and input for input element events.