Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support time in oh-input widget #2214

Merged
merged 1 commit into from Dec 12, 2023
Merged

Conversation

mherwege
Copy link
Contributor

Time only was not supported so far in the oh-input widget.

This was requested in the community forum: https://community.openhab.org/t/using-a-user-input/151884/9

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege mherwege requested a review from a team as a code owner December 12, 2023 16:59
Copy link

relativeci bot commented Dec 12, 2023

Job #1306: Bundle Size — 15.82MiB (+0.37%).

f86f96a(current) vs b7270d2 main#1158(baseline)

Important

Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages

Warning

Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages

Bundle metrics  Change 10 changes Regression 5 regressions Improvement 1 improvement
                 Current
Job #1306
     Baseline
Job #1158
Regression  Initial JS 1.9MiB(+13.73%) 1.67MiB
Regression  Initial CSS 609.63KiB(+0.12%) 608.89KiB
Change  Cache Invalidation 93.81% 93.95%
Change  Chunks 217(-0.91%) 219
Change  Assets 683(-0.87%) 689
Change  Modules 3028(+78.12%) 1700
Regression  Duplicate Modules 170(+88.89%) 90
Improvement  Duplicate Code 1.6%(-17.95%) 1.95%
Regression  Packages 152(+10.14%) 138
Regression  Duplicate Packages 16(+6.67%) 15
Bundle size by type  Change 3 changes Regression 3 regressions
                 Current
Job #1306
     Baseline
Job #1158
Regression  JS 9.29MiB (+0.41%) 9.25MiB
Regression  Other 4.75MiB (+0.41%) 4.73MiB
Regression  CSS 860.86KiB (+0.16%) 859.49KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1306 reportView mherwege:oh-input branch activity

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I will create a follow-up PR to update the component param description and avoid a few errors being thrown ...

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Dec 12, 2023
@florian-h05 florian-h05 added this to the 4.1 milestone Dec 12, 2023
@florian-h05 florian-h05 merged commit be188e3 into openhab:main Dec 12, 2023
6 checks passed
florian-h05 added a commit to florian-h05/openhab-webui that referenced this pull request Dec 12, 2023
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05 added a commit that referenced this pull request Dec 12, 2023
- Update component docs (follow-up for #2214).
- Avoid sending "Invalid date" to server and do not accept "Invalid
date" as a valid state.
- Fix some errors thrown while configuring component or providing
invalid input.

---------

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@mherwege mherwege deleted the oh-input branch December 13, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants