[BasicUI] Move most of app settings to per-device (browser) settings #2243
Conversation
lolodomo
force-pushed
the
basicui_localstorage_2
branch
4 times, most recently
from
ee91e3d
to
afe6eee
Compare
lolodomo
changed the title
lolodomo
force-pushed
the
basicui_localstorage_2
branch
2 times, most recently
from
31795e0
to
bb3d582
Compare
lolodomo
force-pushed
the
basicui_localstorage_2
branch
13 times, most recently
from
390bfb3
to
9736508
Compare
lolodomo
changed the title
lolodomo
force-pushed
the
basicui_localstorage_2
branch
5 times, most recently
from
ca80718
to
c4778a7
Compare
|
This PR is finally ready for review. The home icon at top left has been replaced by a setting icon.
When clicking on it, you open the page with all settings:
In case you open the settings page in a separate tab or window, your changes are immediately applied to your other tab/window opened on Basic UI. |
|
I have of course tested all these settings. Regarding the "web audio" setting, first you have to know that the web audio is ready only when you are on a sitemap page, not when you are on the settings page or the list of sitemaps page. Nothing new here. The enabling/disabling of the "web audio" is working well in Chrome and Edge. In firefox on Windows 10, you have in fact to restart Firefox after enabling/disabling it to have it working, maybe a bug in Firefox. If you are in mode auto for the theme, Baisc UI will now automatically change theme without the need to refresh the page. |
|
Only 2 settings remain on server side:
|
lolodomo
force-pushed
the
basicui_localstorage_2
branch
2 times, most recently
from
c88e8b3
to
fce51f7
Compare
Closes openhab#1832 Closes openhab#1930 Closes openhab#2342 A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap. Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI. Web Audio can also be enabled either in Main UI or Basic UI. The iconify setting is now enabled by default. The script to handle iconify icons is now loaded in sitemap pages only if the iconify setting is enabled. New settings are also available to control the size of the chart and the size of content (text, line) in the chart. A new setting is also available to enable a bigger font size. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
force-pushed
the
basicui_localstorage_2
branch
from
fce51f7
to
f3e9e54
Compare
|
With bigger font size disabled:
With bigger font size enabled:
|
|
That's cool, thank you for the review. |
|
Seems to work well and it looks pretty nice - thanks again! |
Closes #1832
Closes #1930
Closes #2342
A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.
The iconify setting is now enabled by default. The script to handle iconify icons is now loaded in sitemap pages only if the iconify setting is enabled.
New settings are also available to control the size of the chart and the size of content (text, line) in the chart.
A new setting is also available to enable a bigger font size.
Signed-off-by: Laurent Garnier lg.hc@free.fr