Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings pages: Fix x-overflow and large spaces on phone screens & Change icon for persistence config #2248

Merged
merged 5 commits into from Dec 30, 2023
Merged

Settings pages: Fix x-overflow and large spaces on phone screens & Change icon for persistence config #2248

merged 5 commits into from Dec 30, 2023

Conversation

florian-h05
Copy link
Contributor

Follow-up for #2229.

@florian-h05
Fix x-overflow on phone screens & Remove redundant CSS
ee7eebb 
Fixes x-overflow on phone screens, where it was possible to scroll horizontally.
Remove the service-config class where the class declaration was missing and instead apply the used CSS directly on config-sheet.vue.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Fix large space between blocks on add-on config & persistence config …
747846c 
…page on phones

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Fix persistence config button to wide on phone screens
c97e288 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Change icon for persistence settings menu entry
20fa754 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner December 30, 2023 14:27
@relativeci RelativeCI
Copy link

relativeci bot commented Dec 30, 2023 •
edited

Job #1340: Bundle Size — 15.84MiB (+0.52%).

7b2ef57(current) vs b7270d2 main#1158(baseline)

Important

Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages

Warning

Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages

Bundle metrics  Change 10 changes Regression 5 regressions Improvement 1 improvement
                 Current
Job #1340		      Baseline
Job #1158
Regression  Initial JS 1.9MiB(+13.83%) 1.67MiB
Regression  Initial CSS 609.81KiB(+0.15%) 608.89KiB
Change  Cache Invalidation 93.81% 93.95%
Change  Chunks 217(-0.91%) 219
Change  Assets 683(-0.87%) 689
Change  Modules 3036(+78.59%) 1700
Regression  Duplicate Modules 170(+88.89%) 90
Improvement  Duplicate Code 1.6%(-17.95%) 1.95%
Regression  Packages 152(+10.14%) 138
Regression  Duplicate Packages 16(+6.67%) 15
Bundle size by type  Change 3 changes Regression 3 regressions
                 Current
Job #1340		      Baseline
Job #1158
Regression  JS 9.31MiB (+0.6%) 9.25MiB
Regression  Other 4.75MiB (+0.53%) 4.73MiB
Regression  CSS 861.35KiB (+0.22%) 859.49KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1340 report View florian-h05:style-fixes-icon branch activity

@florian-h05
Minor style improvements
7b2ef57 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 merged commit bf2f257 into openhab:main Dec 30, 2023
6 checks passed
@florian-h05 florian-h05 deleted the style-fixes-icon branch December 30, 2023 14:47
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jan 6, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@florian-h05